You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/19 15:54:13 UTC
[GitHub] [camel-kafka-connector] orpiske opened a new pull request #53:
Added support for testing the Kafka service using Strimzi
orpiske opened a new pull request #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53
Also updates the default Kafka service to use the containers from the Strimzi project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] valdar commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
valdar commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-572272888
@oscerd what is your opinion on this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] oscerd commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-572278224
I don't like docker compose at all.. but I understand it could be useful in
this case
Il mer 8 gen 2020, 22:48 Andrea Tarocchi <no...@github.com> ha
scritto:
> @oscerd <https://github.com/oscerd> what is your opinion on this one?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-kafka-connector/pull/53?email_source=notifications&email_token=ABG6XVYKRCZY2R6URG7WUSDQ4ZC3FA5CNFSM4J5JURSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIODB6A#issuecomment-572272888>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABG6XVY4U7C45PMIUHVB6BDQ4ZC3FANCNFSM4J5JURSA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] orpiske commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-567906510
> Mmm I'd stay away from compose if possible, isn't there an easy way to run those 2 containers by hand?
I think there is. I actually considered doing this at first, but ended up going for the Docker Compose solution since it would be simpler and require less code. I don't think doing this orchestration by hand would be significantly more complex, tough. Probably just a bit more code.
Let me get back to the code and see how it would look like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] orpiske commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-568059016
> I mean don't get me wrong, if it is an effort just stick with the compose solution that is used in other oss projects as well so...
That's OK. I think it's a valid point and, since the effort wouldn't be too much, it was worth taking a look and see the result.
I implemented a simple version of this using only containers: https://github.com/orpiske/camel-kafka-connector/compare/master...orpiske:replace-kafka-2?expand=1
I still prefer the docker compose approach because it seems cleaner to me, but I don't have a strong preference. If you think that is a better approach, I can definitely clean it up and replace the commits here with those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] valdar commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
valdar commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-567988005
I mean don't get me wrong, if it is an effort just stick with the compose solution that is used in other oss projects as well so...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] valdar closed pull request #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
valdar closed pull request #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] valdar commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
valdar commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-567867265
Mmm I'd stay away from compose if possible, isn't there an easy way to run those 2 containers by hand?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-kafka-connector] valdar commented on issue #53: Added
support for testing the Kafka service using Strimzi
Posted by GitBox <gi...@apache.org>.
valdar commented on issue #53: Added support for testing the Kafka service using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/53#issuecomment-572899766
Let's start with the version without docker compose we have here: https://github.com/apache/camel-kafka-connector/pull/66 we can always revert to this approach if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services