[GitHub] [buildstream] juergbi commented on a diff in pull request #1680: Use `StageTree` to stage previous sources

[GitBox <gi...@apache.org>]

juergbi commented on code in PR #1680:
URL: https://github.com/apache/buildstream/pull/1680#discussion_r920893359


##########
src/buildstream/_cas/cascache.py:
##########
@@ -443,6 +443,48 @@ def import_directory(self, path: str, properties: Optional[List[str]] = None) ->
 
         return utils._message_digest(root_directory)
 
+    # stage_directory():
+    #
+    # A contextmanager to stage a CAS directory tree in the local filesystem.
+    #
+    # This makes the specified directory tree temporarily available for local
+    # filesystem access. This may use FUSE or hardlinking.

Review Comment:
   `StageTree` is the same method that is also used by buildbox-run-bubblewrap. I.e. this shouldn't add any risk. For safe hardlinking, buildbox-casd has to run as a different user, in which case this should be safe for both build sandboxes and sources.
   
   That said, I don't remember whether we already verify that the setup is correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org