You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/06 16:08:43 UTC
Review Request 72744: Added a scheduler API test for a valid offer
constraints update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72744/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10171
https://issues.apache.org/jira/browse/MESOS-10171
Repository: mesos
Description
-------
Added a scheduler API test for a valid offer constraints update.
Diffs
-----
src/tests/master/update_framework_tests.cpp 514647dd2fbd4b901b5f57a81fded949af12432a
Diff: https://reviews.apache.org/r/72744/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72744: Added a scheduler API test for a valid offer
constraints update.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
> On Aug. 19, 2020, 6:18 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 761-770 (patched)
> > <https://reviews.apache.org/r/72744/diff/2/?file=2238080#file2238080line761>
> >
> > Per comment on previous review, could consider using json for this? (ditto below)
I'm inclined to set constraints via protobuf methods in this specific case: I would rather be explicit that the role in constraint is synchronized with `FrameworkInfo`.
Given that, and also that the constraints themselves are very simple, and adding the need to pull `OfferConstraints` into `Subscribe`/`UpdateFramework`, I doubt that JSON will be of much help here,
> On Aug. 19, 2020, 6:18 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 789-798 (patched)
> > <https://reviews.apache.org/r/72744/diff/2/?file=2238080#file2238080line789>
> >
> > Hm.. I would have guessed this reads from the /frameworks endpoint (or v1 GET_FRAMEWORKS call) to check the state change.
> >
> > Testing that it gets propagated to the allocator also make sense though.
> >
> > Perhaps we should check both?
Good point! We definitely should, after they are exposed. Added a JIRA for that and TODO here.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72744/#review221643
-----------------------------------------------------------
On Aug. 20, 2020, 8:58 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72744/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2020, 8:58 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10171
> https://issues.apache.org/jira/browse/MESOS-10171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a scheduler API test for a valid offer constraints update.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 514647dd2fbd4b901b5f57a81fded949af12432a
>
>
> Diff: https://reviews.apache.org/r/72744/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72744: Added a scheduler API test for a valid offer
constraints update.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72744/#review221643
-----------------------------------------------------------
Ship it!
src/tests/master/update_framework_tests.cpp
Lines 755 (patched)
<https://reviews.apache.org/r/72744/#comment310713>
Maybe this is more consistent?
```
EXPECT_CALL(*scheduler, connected(_))
.WillOnce(Invoke([](Mesos* mesos) {
XXX
}));
```
src/tests/master/update_framework_tests.cpp
Lines 761-770 (patched)
<https://reviews.apache.org/r/72744/#comment310714>
Per comment on previous review, could consider using json for this? (ditto below)
src/tests/master/update_framework_tests.cpp
Lines 789-798 (patched)
<https://reviews.apache.org/r/72744/#comment310715>
Hm.. I would have guessed this reads from the /frameworks endpoint (or v1 GET_FRAMEWORKS call) to check the state change.
Testing that it gets propagated to the allocator also make sense though.
Perhaps we should check both?
- Benjamin Mahler
On Aug. 14, 2020, 4:59 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72744/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2020, 4:59 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10171
> https://issues.apache.org/jira/browse/MESOS-10171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a scheduler API test for a valid offer constraints update.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 514647dd2fbd4b901b5f57a81fded949af12432a
>
>
> Diff: https://reviews.apache.org/r/72744/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72744: Added a scheduler API test for a valid offer
constraints update.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72744/
-----------------------------------------------------------
(Updated Aug. 20, 2020, 8:58 a.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10171
https://issues.apache.org/jira/browse/MESOS-10171
Repository: mesos
Description
-------
Added a scheduler API test for a valid offer constraints update.
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 514647dd2fbd4b901b5f57a81fded949af12432a
Diff: https://reviews.apache.org/r/72744/diff/3/
Changes: https://reviews.apache.org/r/72744/diff/2-3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72744: Added a scheduler API test for a valid offer
constraints update.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72744/
-----------------------------------------------------------
(Updated Aug. 14, 2020, 4:59 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10171
https://issues.apache.org/jira/browse/MESOS-10171
Repository: mesos
Description
-------
Added a scheduler API test for a valid offer constraints update.
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 514647dd2fbd4b901b5f57a81fded949af12432a
Diff: https://reviews.apache.org/r/72744/diff/2/
Changes: https://reviews.apache.org/r/72744/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko