You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2017/04/06 21:25:03 UTC
Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-7311
https://issues.apache.org/jira/browse/MESOS-7311
Repository: mesos
Description
-------
Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
Diffs
-----
src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
Diff: https://reviews.apache.org/r/58247/diff/1/
Testing
-------
On Windows:
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CopyFetcherPluginTest
[ RUN ] CopyFetcherPluginTest.FetchExistingFile
[ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
[----------] 1 test from CopyFetcherPluginTest (99 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1937 ms total)
[ PASSED ] 1 test.
On Linux:
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CopyFetcherPluginTest
[ RUN ] CopyFetcherPluginTest.FetchExistingFile
[ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
[----------] 1 test from CopyFetcherPluginTest (51 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (77 ms total)
[ PASSED ] 1 test.
Thanks,
Jeff Coffler
Re: Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171272
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On April 6, 2017, 9:25 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58247/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 9:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7311
> https://issues.apache.org/jira/browse/MESOS-7311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
>
>
> Diffs
> -----
>
> src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
>
>
> Diff: https://reviews.apache.org/r/58247/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
> [----------] 1 test from CopyFetcherPluginTest (99 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1937 ms total)
> [ PASSED ] 1 test.
>
>
> On Linux:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
> [----------] 1 test from CopyFetcherPluginTest (51 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (77 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On April 6, 2017, 4:10 p.m., Andrew Schwartzmeyer wrote:
> > src/uri/fetchers/copy.cpp
> > Line 98 (original), 99-104 (patched)
> > <https://reviews.apache.org/r/58247/diff/1/?file=1686263#file1686263line99>
> >
> > I think I would have named it `path` over `baseCommand`, and remove the trailing whitespace, but otherwise, great!
>
> Joseph Wu wrote:
> Mostly minor nits from me, which I can fix before committing.
>
> * `// ifndef __WINDOWS__` can be `// __WINDOWS__`
> * I'd actually go for `copyCommand` instead of `baseCommand` or `path` :P
> * Instead of a character pointer, we prefer `const char copyCommand[]` for const c-strings.
>
> Jeff Coffler wrote:
> I actually did the `#ifndef` intentionally, I tend to do the "primary" paths first, save the `#else` for the rarer cases. I thought Linux was more common, so I handled that first.
>
> All of this was style stuff, I'm fine with that. Do you have a coding standards doc I can look at, or do committers just pick this up with time?
Style doc here: http://mesos.apache.org/documentation/latest/c++-style-guide/
We basically follow the Google C++ style guide, plus a few rules of our own.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171271
-----------------------------------------------------------
On April 6, 2017, 2:25 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58247/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 2:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7311
> https://issues.apache.org/jira/browse/MESOS-7311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
>
>
> Diffs
> -----
>
> src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
>
>
> Diff: https://reviews.apache.org/r/58247/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
> [----------] 1 test from CopyFetcherPluginTest (99 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1937 ms total)
> [ PASSED ] 1 test.
>
>
> On Linux:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
> [----------] 1 test from CopyFetcherPluginTest (51 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (77 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On April 6, 2017, 4:10 p.m., Andrew Schwartzmeyer wrote:
> > src/uri/fetchers/copy.cpp
> > Line 98 (original), 99-104 (patched)
> > <https://reviews.apache.org/r/58247/diff/1/?file=1686263#file1686263line99>
> >
> > I think I would have named it `path` over `baseCommand`, and remove the trailing whitespace, but otherwise, great!
Mostly minor nits from me, which I can fix before committing.
* `// ifndef __WINDOWS__` can be `// __WINDOWS__`
* I'd actually go for `copyCommand` instead of `baseCommand` or `path` :P
* Instead of a character pointer, we prefer `const char copyCommand[]` for const c-strings.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171271
-----------------------------------------------------------
On April 6, 2017, 2:25 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58247/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 2:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7311
> https://issues.apache.org/jira/browse/MESOS-7311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
>
>
> Diffs
> -----
>
> src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
>
>
> Diff: https://reviews.apache.org/r/58247/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
> [----------] 1 test from CopyFetcherPluginTest (99 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1937 ms total)
> [ PASSED ] 1 test.
>
>
> On Linux:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
> [----------] 1 test from CopyFetcherPluginTest (51 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (77 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
Posted by Jeff Coffler <je...@taltos.com>.
> On April 6, 2017, 11:10 p.m., Andrew Schwartzmeyer wrote:
> > src/uri/fetchers/copy.cpp
> > Line 98 (original), 99-104 (patched)
> > <https://reviews.apache.org/r/58247/diff/1/?file=1686263#file1686263line99>
> >
> > I think I would have named it `path` over `baseCommand`, and remove the trailing whitespace, but otherwise, great!
>
> Joseph Wu wrote:
> Mostly minor nits from me, which I can fix before committing.
>
> * `// ifndef __WINDOWS__` can be `// __WINDOWS__`
> * I'd actually go for `copyCommand` instead of `baseCommand` or `path` :P
> * Instead of a character pointer, we prefer `const char copyCommand[]` for const c-strings.
I actually did the `#ifndef` intentionally, I tend to do the "primary" paths first, save the `#else` for the rarer cases. I thought Linux was more common, so I handled that first.
All of this was style stuff, I'm fine with that. Do you have a coding standards doc I can look at, or do committers just pick this up with time?
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171271
-----------------------------------------------------------
On April 6, 2017, 9:25 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58247/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 9:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7311
> https://issues.apache.org/jira/browse/MESOS-7311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
>
>
> Diffs
> -----
>
> src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
>
>
> Diff: https://reviews.apache.org/r/58247/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
> [----------] 1 test from CopyFetcherPluginTest (99 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1937 ms total)
> [ PASSED ] 1 test.
>
>
> On Linux:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
> [----------] 1 test from CopyFetcherPluginTest (51 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (77 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171271
-----------------------------------------------------------
src/uri/fetchers/copy.cpp
Line 98 (original), 99-104 (patched)
<https://reviews.apache.org/r/58247/#comment244167>
I think I would have named it `path` over `baseCommand`, and remove the trailing whitespace, but otherwise, great!
- Andrew Schwartzmeyer
On April 6, 2017, 9:25 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58247/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 9:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7311
> https://issues.apache.org/jira/browse/MESOS-7311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
>
>
> Diffs
> -----
>
> src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
>
>
> Diff: https://reviews.apache.org/r/58247/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
> [----------] 1 test from CopyFetcherPluginTest (99 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1937 ms total)
> [ PASSED ] 1 test.
>
>
> On Linux:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
> [----------] 1 test from CopyFetcherPluginTest (51 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (77 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58247: Windows: Fixed test
CopyFetcherPluginTest.FetchExistingFile.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171304
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58247]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 6, 2017, 9:25 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58247/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 9:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-7311
> https://issues.apache.org/jira/browse/MESOS-7311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Fixed test CopyFetcherPluginTest.FetchExistingFile.
>
>
> Diffs
> -----
>
> src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
>
>
> Diff: https://reviews.apache.org/r/58247/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (97 ms)
> [----------] 1 test from CopyFetcherPluginTest (99 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1937 ms total)
> [ PASSED ] 1 test.
>
>
> On Linux:
>
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from CopyFetcherPluginTest
> [ RUN ] CopyFetcherPluginTest.FetchExistingFile
> [ OK ] CopyFetcherPluginTest.FetchExistingFile (51 ms)
> [----------] 1 test from CopyFetcherPluginTest (51 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (77 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Jeff Coffler
>
>