You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/04/16 13:17:38 UTC

[commons-numbers] 03/03: Use correct FractionException constant in Fraction constructor

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit aa243b33be0eccd3878d46b7ac485e048c2a2dbd
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Thu Apr 16 14:17:30 2020 +0100

    Use correct FractionException constant in Fraction constructor
---
 .../src/main/java/org/apache/commons/numbers/fraction/Fraction.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
index 22e30c2..1974f1e 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
@@ -157,7 +157,7 @@ public final class Fraction
         double r0 = value;
         long a0 = (long)Math.floor(r0);
         if (Math.abs(a0) > overflow) {
-            throw new FractionException(FractionException.ERROR_CONVERSION, value, a0, 1L);
+            throw new FractionException(FractionException.ERROR_CONVERSION_OVERFLOW, value, a0, 1L);
         }
 
         // check for (almost) integer arguments, which should not go to iterations.
@@ -192,7 +192,7 @@ public final class Fraction
                     Math.abs(q1) < maxDenominator) {
                     break;
                 }
-                throw new FractionException(FractionException.ERROR_CONVERSION, value, p2, q2);
+                throw new FractionException(FractionException.ERROR_CONVERSION_OVERFLOW, value, p2, q2);
             }
 
             final double convergent = (double)p2 / (double)q2;