You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "MarigWeizhi (via GitHub)" <gi...@apache.org> on 2024/08/17 07:41:53 UTC
[PR] [AMORO-3104] Added table summary metrics [amoro]
MarigWeizhi opened a new pull request, #3109:
URL: https://github.com/apache/amoro/pull/3109
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3104.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Added `TableSummaryMetrics` for each table to help users better understand the detail of tables.
- Changed the structure of `OptimizingEvaluator.PendingInput`
## How was this patch tested?
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3104] Added table summary metrics [amoro]
Posted by "MarigWeizhi (via GitHub)" <gi...@apache.org>.
MarigWeizhi commented on PR #3109:
URL: https://github.com/apache/amoro/pull/3109#issuecomment-2317056454
> Thanks for the contribution!
>
> All changes look good to me except a minor issue.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3104] Added table summary metrics [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3109:
URL: https://github.com/apache/amoro/pull/3109#issuecomment-2317059200
Thanks for the contribution! @MarigWeizhi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3104] Added table summary metrics [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #3109:
URL: https://github.com/apache/amoro/pull/3109#discussion_r1735813729
##########
amoro-ams/amoro-ams-server/src/main/resources/postgres/ams-postgres-init.sql:
##########
@@ -211,6 +212,7 @@ COMMENT ON COLUMN table_runtime.optimizer_group IS 'Optimizer group';
COMMENT ON COLUMN table_runtime.table_config IS 'Table-specific configuration';
COMMENT ON COLUMN table_runtime.optimizing_config IS 'Optimizing configuration';
COMMENT ON COLUMN table_runtime.pending_input IS 'Pending input data';
+COMMENT ON COLUMN table_runtime.table_summary IS 'Table Summary data';
Review Comment:
```suggestion
COMMENT ON COLUMN table_runtime.table_summary IS 'Table summary data';
```
##########
amoro-ams/amoro-ams-server/src/main/resources/postgres/upgrade.sql:
##########
@@ -22,3 +22,7 @@ ALTER TABLE `table_blocker` DROP INDEX `table_index`;
ALTER TABLE `table_blocker` ADD COLUMN `prev_blocker_id` bigint(20) NOT NULL DEFAULT -1;
COMMENT ON COLUMN table_blocker.prev_blocker_id IS 'prev blocker id when created';
ALTER TABLE `table_blocker` ADD UNIQUE KEY `uq_prev` (`catalog_name`,`db_name`,`table_name`, `prev_blocker_id`);
+
+-- ADD COLUMN table_summary FOR TABLE_RUNTIME
+ALTER TABLE table_runtime ADD COLUMN table_summary TEXT;
+COMMENT ON COLUMN table_runtime.table_summary IS 'Table Summary data';
Review Comment:
```suggestion
COMMENT ON COLUMN table_runtime.table_summary IS 'Table summary data';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3104] Added table summary metrics [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3109:
URL: https://github.com/apache/amoro/pull/3109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org