[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1755: SOLR-14753: Improve thread annotation name

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #1755:
URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r471379456



##########
File path: solr/solrj/src/java/org/apache/solr/common/annotation/SolrThreadUnsafe.java
##########
@@ -29,6 +29,6 @@
 @Documented
 @Retention(SOURCE)
 @Target(TYPE)
-public @interface SolrSingleThreaded {

Review comment:
       Via https://issues.apache.org/jira/browse/SOLR-13998 the `SolrSingleThreaded` public interface was included in releases from https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.4.0/solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java onwards. And so potentially folks could be using it in their custom code built against 8.4 onwards, though this might be unlikely in practice perhaps, it's difficult to know.
   
   I wonder if we have or want to have some sort of backwards compatibility support for annotations? E.g. the scope of this pull request here could become _"Add SolrThreadUnsafe annotation, deprecate SolrSingleThreaded annotation."_ i.e. we keep `SolrSingleThreaded` around as deprecated for the remainder of the 8x releases and a separate commit for master branch only would remove the deprecated interface from 9.0 onwards.
   
   Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org