You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/18 20:44:00 UTC

[GitHub] [nifi-registry] kevdoran commented on a change in pull request #169: NIFIREG-216 Add S3 BundlePersistenceProvider

kevdoran commented on a change in pull request #169: NIFIREG-216 Add S3 BundlePersistenceProvider
URL: https://github.com/apache/nifi-registry/pull/169#discussion_r276821846
 
 

 ##########
 File path: nifi-registry-assembly/pom.xml
 ##########
 @@ -423,5 +423,43 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>include-aws</id>
 
 Review comment:
   I like making this provider an optional extension, but is there any reason not to include it by default (i.e., licensing or binary size).
   
   Or do you think for our Apache convenience binary builds we will include this profile? I think it would be pretty popular. Just wondering if we need to discuss before the next release, and maybe update the RM guide to specify if this profile should be active for convenience binary builds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services