You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 15:05:59 UTC

[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #201: feat(c/driver/sqlite): add Python SQLite driver bindings

lidavidm commented on code in PR #201:
URL: https://github.com/apache/arrow-adbc/pull/201#discussion_r1036087312


##########
c/driver/sqlite/sqlite.c:
##########
@@ -1783,6 +1783,9 @@ AdbcStatusCode AdbcStatementExecutePartitions(struct AdbcStatement* statement,
 }  // NOLINT(whitespace/indent)
 // due to https://github.com/cpplint/cpplint/pull/189
 
+extern "C" {

Review Comment:
   ```suggestion
   ```



##########
c/driver/sqlite/sqlite.c:
##########
@@ -1783,6 +1783,9 @@ AdbcStatusCode AdbcStatementExecutePartitions(struct AdbcStatement* statement,
 }  // NOLINT(whitespace/indent)
 // due to https://github.com/cpplint/cpplint/pull/189
 
+extern "C" {
+ADBC_EXPORT
 AdbcStatusCode AdbcDriverInit(int version, void* driver, struct AdbcError* error) {
   return SqliteDriverInit(version, driver, error);
 }
+}

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org