You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zhaohehuhu (via GitHub)" <gi...@apache.org> on 2023/11/06 08:05:46 UTC
[PR] Set session affinity if needed in helm chart [kyuubi]
zhaohehuhu opened a new pull request, #5631:
URL: https://github.com/apache/kyuubi/pull/5631
This can ensure that incoming request from same client are forward to the same Kyuubi service instance in K8S. maybe a workaround for users to get their session state each time.
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5748][K8S][HELM] Set session affinity if needed in helm chart [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#issuecomment-1822080111
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5748][K8S][HELM] Set session affinity if needed in helm chart [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5631: [KYUUBI #5748][K8S][HELM] Set session affinity if needed in helm chart
URL: https://github.com/apache/kyuubi/pull/5631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1386155704
##########
charts/kyuubi/values.yaml:
##########
@@ -235,3 +235,9 @@ prometheusRule:
enabled: false
# Contents of Prometheus rules file
groups: []
+
+service:
+ sessionAffinity: None
Review Comment:
> what's the value candidates?
ClientIP or None. Do we need to add a hint for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Set session affinity if needed in helm chart [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#issuecomment-1794280703
Hi @pan3793, plz review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1386160059
##########
charts/kyuubi/values.yaml:
##########
@@ -235,3 +235,9 @@ prometheusRule:
enabled: false
# Contents of Prometheus rules file
groups: []
+
+service:
+ sessionAffinity: None
Review Comment:
Yes, otherwise the user has no idea how to deal with that.
Additionally, I suppose the content could be flexible, if yes, I suppose we should ref the yaml snippets directly, like `resources` in line 175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1385891703
##########
charts/kyuubi/values.yaml:
##########
@@ -235,3 +235,9 @@ prometheusRule:
enabled: false
# Contents of Prometheus rules file
groups: []
+
+service:
+ sessionAffinity: None
Review Comment:
what's the value candidates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1391925924
##########
charts/kyuubi/values.yaml:
##########
@@ -115,6 +133,12 @@ server:
port: "{{ .Values.server.mysql.port }}"
nodePort: ~
annotations: {}
+ #candidates are ClientIP or None, ClientIP is required to set if session affinity is enabled
+ sessionAffinity: ~
+ #default is 10800s
+ sessionAffinityConfig:
+ clientIP:
+ timeoutSeconds: ~
Review Comment:
> this could be flexible once K8s supports other session affinity strategies. let's use toYaml approach
Refactored. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#issuecomment-1805122625
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5631?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5631](https://app.codecov.io/gh/apache/kyuubi/pull/5631?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a3a7099) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/f23b6de6b3751fc2592eb834107b7381cf7ce130?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f23b6de) will **increase** coverage by `0.07%`.
> Report is 18 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head a3a7099 differs from pull request most recent head f753ee3. Consider uploading reports for the commit f753ee3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5631 +/- ##
============================================
+ Coverage 61.36% 61.43% +0.07%
Complexity 23 23
============================================
Files 603 603
Lines 35635 35635
Branches 4874 4874
============================================
+ Hits 21867 21892 +25
+ Misses 11387 11362 -25
Partials 2381 2381
```
[see 16 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/5631/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1388924498
##########
charts/kyuubi/values.yaml:
##########
@@ -235,3 +235,9 @@ prometheusRule:
enabled: false
# Contents of Prometheus rules file
groups: []
+
+service:
+ sessionAffinity: None
Review Comment:
Got it. The content should be fixed, but I try to make a improvement. @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1391911173
##########
charts/kyuubi/values.yaml:
##########
@@ -115,6 +133,12 @@ server:
port: "{{ .Values.server.mysql.port }}"
nodePort: ~
annotations: {}
+ #candidates are ClientIP or None, ClientIP is required to set if session affinity is enabled
+ sessionAffinity: ~
+ #default is 10800s
+ sessionAffinityConfig:
+ clientIP:
+ timeoutSeconds: ~
Review Comment:
sounds good. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [K8S][HELM]Set session affinity if needed in helm chart [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5631:
URL: https://github.com/apache/kyuubi/pull/5631#discussion_r1391046413
##########
charts/kyuubi/values.yaml:
##########
@@ -115,6 +133,12 @@ server:
port: "{{ .Values.server.mysql.port }}"
nodePort: ~
annotations: {}
+ #candidates are ClientIP or None, ClientIP is required to set if session affinity is enabled
+ sessionAffinity: ~
+ #default is 10800s
+ sessionAffinityConfig:
+ clientIP:
+ timeoutSeconds: ~
Review Comment:
this could be flexible once K8s supports other session affinity strategies. let's use toYaml approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org