[jira] [Commented] (CAMEL-6670) Throttler EIP - Add JMX attribute to know if hit limit currently (eg its throttling state)

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792552#comment-13792552 ] 

Claus Ibsen commented on CAMEL-6670:
------------------------------------

Thanks for the patch and tests. 

Looks good, I just made the inc/dec counter logic a bit simpler to not be needed in the async callback. This also ensures we dec the counter as soon as we start procesing the exchange, so the counter is fully up to date.

We should expose the JMX attribute in ManagedDelayer also. Christian do you want to work on a patch with that?

> Throttler EIP - Add JMX attribute to know if hit limit currently (eg its throttling state)
> ------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-6670
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6670
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core, eip, jmx
>            Reporter: Claus Ibsen
>            Assignee: Christian Posta
>            Priority: Minor
>             Fix For: 2.12.2, 2.13.0
>
>         Attachments: CAMEL-6670.patch
>
>
> See SO
> http://stackoverflow.com/questions/18446689/how-to-get-the-information-that-throttling-limit-has-been-reached
> We would need to extend the org.apache.camel.processor.Throttler so it keeps state whether its holding back exchanges due hit limit, or not. Wonder what a name should be. It could be a simple boolean to indicate that. And/or a counter that counts the number of exchanges being hold back. Then ppl can have a graph with the counter.
> This data should be exposed in JMX with org.apache.camel.api.management.mbean.ManagedThrottlerMBean



--
This message was sent by Atlassian JIRA
(v6.1#6144)