You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/04 17:07:06 UTC
[GitHub] [airflow] ashb opened a new pull request #19408: Define datetime and StringID column types centrally in migrations
ashb opened a new pull request #19408:
URL: https://github.com/apache/airflow/pull/19408
We have various flavours of the code all over the place in many
migration files -- which leads to duplication and things not being in
sync.
This pulls them once in to a central location.
I had to make a slight change to the DB test to ensure that the migrations are evaluted/loaded with an active Alembic context given the changed way of detecting the current engine type in db_types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #19408: Define datetime and StringID column types centrally in migrations
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #19408:
URL: https://github.com/apache/airflow/pull/19408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #19408: Define datetime and StringID column types centrally in migrations
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #19408:
URL: https://github.com/apache/airflow/pull/19408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19408: Define datetime and StringID column types centrally in migrations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19408:
URL: https://github.com/apache/airflow/pull/19408#issuecomment-962644507
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19408: Define datetime and StringID column types centrally in migrations
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19408:
URL: https://github.com/apache/airflow/pull/19408#issuecomment-962644457
nice use of stubs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org