You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/25 04:02:45 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #43090: [SPARK-45304][BUILD] Remove test classloader workaround for SBT build
HyukjinKwon opened a new pull request, #43090:
URL: https://github.com/apache/spark/pull/43090
### What changes were proposed in this pull request?
This PR proposes to remove the workaround for JDK 8 in SBT build, see https://github.com/apache/spark/pull/30198
### Why are the changes needed?
We don't need this with JDK 11+ anymore, see https://github.com/apache/spark/pull/30198.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #43090: [SPARK-45304][BUILD] Remove test classloader workaround for SBT build
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43090:
URL: https://github.com/apache/spark/pull/43090#issuecomment-1732870726
This one I am pretty sure as it reverts my own PR :-). I am going to merge this when the tests pass - it's a clean revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #43090: [SPARK-45304][BUILD] Remove test classloader workaround for SBT build
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43090: [SPARK-45304][BUILD] Remove test classloader workaround for SBT build
URL: https://github.com/apache/spark/pull/43090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43090: [SPARK-45304][BUILD] Remove test classloader workaround for SBT build
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43090:
URL: https://github.com/apache/spark/pull/43090#issuecomment-1734176498
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org