You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/19 18:19:25 UTC
[GitHub] [airflow] JCoder01 opened a new pull request #14900: Remove dags_folder path from dag.fileloc
JCoder01 opened a new pull request #14900:
URL: https://github.com/apache/airflow/pull/14900
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
JCoder01 commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803310284
Closing MR, "Fixed" this in my local install by monkey patching `TaskInstance.generate_command` in airflow_local_settings.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 edited a comment on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
JCoder01 edited a comment on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803032594
@XD-DENG see https://github.com/apache/airflow/issues/8061. If your workers have have their dags in a different location than the scheduler then the command passed to Celery doesn't work. e.g. if your scheduler has `/opt/airflow/dags` but on your worker the dags are at `/var/airflow` (or in my case in my home dir) then the airflow command that is passed to the worker includes `--subdir /opt/airflow/dags` and files because the dags are actually in a different location. I would also like to point out that this is not new functionality, it existed before and has since broke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803172088
[The Workflow run](https://github.com/apache/airflow/actions/runs/669362827) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803217856
[The Workflow run](https://github.com/apache/airflow/actions/runs/669702086) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803038745
Hi @JCoder01 , even though what you are referring to is not a new functionality, `fileloc` has been an absolute path along the way.
What I would suggest are:
- have a proper PR description here to share why this change is needed. If you didn't provide the link to the Issue, people (at least me) do not know where this PR's idea is coming from.
- I would encourage more concrete discussion on whether the requirement/need raised in the Issue https://github.com/apache/airflow/issues/8061 has to be addressed in this way (or if this is the best way). I don't yet have a good proposal, hence I will cancel my review so that any other committer who finds this change good enough can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
JCoder01 commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803032594
@XD-DENG see https://github.com/apache/airflow/issues/8061. If you your workers have have their dags in a different location than the scheduler then the command passed to Celery doesn't work. e.g. if your scheduler has `/opt/airflow/dags` but on your worker the dags are at `/var/airflow` (or in my case in my home dir) then the airflow command that is passed to the worker includes `--subdir /opt/airflow/dags` and files because the dags are actually in a different location. I would also like to point out that this is not new functionality, it existed before and has since broke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803172203
[The Workflow run](https://github.com/apache/airflow/actions/runs/669363668) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 closed pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
JCoder01 closed pull request #14900:
URL: https://github.com/apache/airflow/pull/14900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803172045
[The Workflow run](https://github.com/apache/airflow/actions/runs/669361655) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 edited a comment on pull request #14900: Remove dags_folder path from dag.fileloc
Posted by GitBox <gi...@apache.org>.
JCoder01 edited a comment on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803032594
@XD-DENG see https://github.com/apache/airflow/issues/8061. If your workers have their dags in a different location than the scheduler then the command passed to Celery doesn't work. e.g. if your scheduler has `/opt/airflow/dags` but on your worker the dags are at `/var/airflow` (or in my case in my home dir) then the airflow command that is passed to the worker includes `--subdir /opt/airflow/dags` and files because the dags are actually in a different location. I would also like to point out that this is not new functionality, it existed before and has since broke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org