You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/08 02:32:02 UTC

[GitHub] [incubator-devlake] keon94 opened a new pull request, #2115: refactor: issue #1711 remove fields from jira model

keon94 opened a new pull request, #2115:
URL: https://github.com/apache/incubator-devlake/pull/2115

   …ds from jira model
   
   ### ⚠️ &nbsp;&nbsp;Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing](https://devlake.apache.org/community/) Documentation & [PR Template](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
   - [ ] This PR is using a `label` (bug, feature etc.)
   - [ ] My code is has necessary documentation (if appropriate)
   - [ ] I have added any relevant tests
   - [ ] This section (**⚠️ &nbsp;&nbsp;Pre Checklist**) will be removed when submitting PR
   
   # Summary
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Does this close any open issues?
   Please mention the issues here.
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on pull request #2115: refactor: issue #1711 remove fields from jira model

Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2115:
URL: https://github.com/apache/incubator-devlake/pull/2115#issuecomment-1150569044

   Hi,  the plan was to remove those fields from `issue` and calculate the latest updated time for differential collection by `changelogs/remotelinks/worklogs` itself,  but this approach had been proven unreliable by @mindlesscloud lately, and my calculation code was removed already, seemed like we have to keep those fields now.
   Sorry I didn't notice the issue earlier and wasted your time.
   I have to close this since it is no longer valid.
   FYI I'm working on issue #2117 to improve the old approach with these fields if you want to know more.
   Feel free to reach out and discuss if you had doubts.
   Again, sorry, it is my fault.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on pull request #2115: refactor: issue #1711 remove fields from jira model

Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2115:
URL: https://github.com/apache/incubator-devlake/pull/2115#issuecomment-1149449896

   @klesh @hezyin please review when you get a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh closed pull request #2115: refactor: issue #1711 remove fields from jira model

Posted by GitBox <gi...@apache.org>.
klesh closed pull request #2115: refactor: issue #1711 remove fields from jira model
URL: https://github.com/apache/incubator-devlake/pull/2115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org