You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/08/05 11:44:18 UTC
Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in
test_persistent_networks.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7240
https://issues.apache.org/jira/browse/CLOUDSTACK-7240
Repository: cloudstack-git
Description
-------
Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True.
Diffs
-----
test/integration/component/test_persistent_networks.py 210063e
Diff: https://reviews.apache.org/r/24305/diff/
Testing
-------
Yes.
test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 1 test in 437.852s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in
test_persistent_networks.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/#review49591
-----------------------------------------------------------
Commit c76302cdd8a70498a792db5d7fbe82ad43b7f8b5 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c76302c ]
CLOUDSTACK-7240: Fixed expunge VM issue in test_persistent_networks.py
Signed-off-by: Santhosh Edukulla <sa...@gmail.com>
- ASF Subversion and Git Services
On Aug. 5, 2014, 9:45 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24305/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 9:45 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7240
> https://issues.apache.org/jira/browse/CLOUDSTACK-7240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py 210063e
>
> Diff: https://reviews.apache.org/r/24305/diff/
>
>
> Testing
> -------
>
> Yes.
>
> test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
> ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 437.852s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in
test_persistent_networks.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Aug. 5, 2014, 12:01 p.m., Santhosh Edukulla wrote:
> > Ship It!
Please change the branch to master, its still open for commits, pushed to master.
64b9ca0..c76302c master -> master
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/#review49589
-----------------------------------------------------------
On Aug. 5, 2014, 9:45 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24305/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 9:45 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7240
> https://issues.apache.org/jira/browse/CLOUDSTACK-7240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py 210063e
>
> Diff: https://reviews.apache.org/r/24305/diff/
>
>
> Testing
> -------
>
> Yes.
>
> test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
> ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 437.852s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in
test_persistent_networks.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/#review49589
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 5, 2014, 9:45 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24305/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 9:45 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7240
> https://issues.apache.org/jira/browse/CLOUDSTACK-7240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py 210063e
>
> Diff: https://reviews.apache.org/r/24305/diff/
>
>
> Testing
> -------
>
> Yes.
>
> test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
> ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 437.852s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in
test_persistent_networks.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 5:33 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7240
https://issues.apache.org/jira/browse/CLOUDSTACK-7240
Repository: cloudstack-git
Description
-------
Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True.
Diffs
-----
test/integration/component/test_persistent_networks.py 210063e
Diff: https://reviews.apache.org/r/24305/diff/
Testing
-------
Yes.
test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 1 test in 437.852s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in
test_persistent_networks.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 3:15 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7240
https://issues.apache.org/jira/browse/CLOUDSTACK-7240
Repository: cloudstack-git
Description
-------
Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True.
Diffs
-----
test/integration/component/test_persistent_networks.py 210063e
Diff: https://reviews.apache.org/r/24305/diff/
Testing
-------
Yes.
test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 1 test in 437.852s
OK
Thanks,
Gaurav Aradhye