You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2020/07/03 06:18:43 UTC
[TEST] Struts 2.5.23 test build is ready
Hi,
Please take a time and test the bits - any help is appreciated. Please
report any problems. I'll call for a vote in a few days if no problems
will be spotted.
Staging Maven repo
https://repository.apache.org/content/groups/staging/
Standalone artifacts
https://dist.apache.org/repos/dist/dev/struts/2.5.23/
Release notes
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.23
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
I have posted the question [1] and probably we will have to set this
[2] - looks like a manual process when preparing a release
[1] https://lists.apache.org/thread.html/r95564f07e23a47072f7d9c373c1accc5a2c4d89d2632f37de4934ced%40%3Cusers.maven.apache.org%3E
[2] https://maven.apache.org/guides/mini/guide-reproducible-builds.html
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
śr., 8 lip 2020 o 04:31 James Chaplin <jc...@apache.org> napisał(a):
>
> Hello Łukasz (and Struts Dev Team).
>
> Sorry for the long response (I was trying to be thorough). :)
>
> I checked out tag STRUTS_2_5_23 and built it locally with JDK7, as you suggested. It produced the same January 5 2020 modification timestamps inside all the zip files produced by the assembly.
>
> Next I examined some other recent 2.5.x project builds assembly zip files from June 2020, and they also have the January 5 2020 modification timestamped contents.
>
> Checking a recent JDK8-built 2.6.0 project build from June 2020 showed it also had the weird January 2020 modification timestamps for its contents. It looks like both 2.5.x and 2.6.x builds are affected the same way. :(
>
> After that, checking a recent 2.3.38-SNAPSHOT build (July 2020) showed that its zip file contents were normal (modification content timestamps in July 2020).
>
> With some digging and comparing maven-assembly-plugin versions for the 2.3.38 vs. 2.5.23 builds it looks like the Maven Assembly Plugin is somehow involved in the issue.
>
> Overriding the maven-assembly-plugin versions in the Struts 2 Assembly the results were:
> - The assembly build produces good zip-content modification timestamps for plugin: 2.6.0, 3.0.0 and 3.1.1.
> - The assembly build produces bad zip-content modification timestamps for plugin: 3.2.0, 3.3.0.
> For 2.5.23 the Maven build uses maven-assembly-plugin 3.2.0 (did not check 2.6).
>
> So the zip incorrect content modification timestamp issues could be a Maven Assembly Plugin bug affecting more recent versions (v3.2.0+) ?
>
> I did a really quick search for a relevant JIRA on this but did not find one. If anyone knows of a JIRA or has seen a similar symptom, please advise.
>
> What to you think ? Should the Struts 2 Assembly POM override the maven-assembly-plugin version in the build(s) to 3.1.1 for now ?
Thanks a lot for digging into it! Looks like the core problem is this
[1] - we are using Apache Master POM ver. 22 which introduced Maven
Assembly Plugin ver. 3.2.0 and new option outputTimestamp [2] and as
we do not override the outputTimestamp in our pom, the value is taken
from the master pom which is [1]
I will post a question to the Maven Users Group about that. Thanks again!
[1] https://github.com/apache/maven-apache-parent/blob/apache-22/pom.xml#L95
[2] http://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#outputTimestamp
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by James Chaplin <jc...@apache.org>.
Hello Łukasz (and Struts Dev Team).
Sorry for the long response (I was trying to be thorough). :)
I checked out tag STRUTS_2_5_23 and built it locally with JDK7, as you suggested. It produced the same January 5 2020 modification timestamps inside all the zip files produced by the assembly.
Next I examined some other recent 2.5.x project builds assembly zip files from June 2020, and they also have the January 5 2020 modification timestamped contents.
Checking a recent JDK8-built 2.6.0 project build from June 2020 showed it also had the weird January 2020 modification timestamps for its contents. It looks like both 2.5.x and 2.6.x builds are affected the same way. :(
After that, checking a recent 2.3.38-SNAPSHOT build (July 2020) showed that its zip file contents were normal (modification content timestamps in July 2020).
With some digging and comparing maven-assembly-plugin versions for the 2.3.38 vs. 2.5.23 builds it looks like the Maven Assembly Plugin is somehow involved in the issue.
Overriding the maven-assembly-plugin versions in the Struts 2 Assembly the results were:
- The assembly build produces good zip-content modification timestamps for plugin: 2.6.0, 3.0.0 and 3.1.1.
- The assembly build produces bad zip-content modification timestamps for plugin: 3.2.0, 3.3.0.
For 2.5.23 the Maven build uses maven-assembly-plugin 3.2.0 (did not check 2.6).
So the zip incorrect content modification timestamp issues could be a Maven Assembly Plugin bug affecting more recent versions (v3.2.0+) ?
I did a really quick search for a relevant JIRA on this but did not find one. If anyone knows of a JIRA or has seen a similar symptom, please advise.
What to you think ? Should the Struts 2 Assembly POM override the maven-assembly-plugin version in the build(s) to 3.1.1 for now ?
Regards,
James.
On 2020/07/07 07:23:11, Lukasz Lenart <lu...@apache.org> wrote:
> wt., 7 lip 2020 o 08:03 Lukasz Lenart <lu...@apache.org> napisał(a):
> > I have no idea how this could happen, I checked the files from
> > assembly/target locally and they are the same, January 5th :\ Let me
> > drop this test build and I will start over.
>
> I gave up, wiped out the whole ~/.m2/repository and started over, used
> "mvn" and "./mvnw" also upgraded Maven Assembly Plugin to 3.3.0 and
> still the same. Used also the "tar.gz" format and the folders have a
> proper date (today) but files are changed.
>
> It looks like Zip is the cause but I have no idea why.
>
> Could you checkout the tag STRUTS_2_5_23 and run "mvn clean package"
> using JDK7 if possible? in assembly/target/assembly/out you should get
> the Zips
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
wt., 7 lip 2020 o 08:03 Lukasz Lenart <lu...@apache.org> napisał(a):
> I have no idea how this could happen, I checked the files from
> assembly/target locally and they are the same, January 5th :\ Let me
> drop this test build and I will start over.
I gave up, wiped out the whole ~/.m2/repository and started over, used
"mvn" and "./mvnw" also upgraded Maven Assembly Plugin to 3.3.0 and
still the same. Used also the "tar.gz" format and the folders have a
proper date (today) but files are changed.
It looks like Zip is the cause but I have no idea why.
Could you checkout the tag STRUTS_2_5_23 and run "mvn clean package"
using JDK7 if possible? in assembly/target/assembly/out you should get
the Zips
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
wt., 7 lip 2020 o 04:45 James Chaplin <jc...@apache.org> napisał(a):
> Yes, those are the files I was referring to (the 2.5.23 test distribution zips).
>
> To clarify, my previous post was talking about the zip-entry modification timestamps of everything *inside* the zip files (not the modification timestamp of the zip files themselves).
>
> If you view any of those zip files using a graphical-based zip tool, or unzip one of them, the modification dates of all the contents (all directories, .jar files, etc.) have a January 5th 2020 modification timestamp. For something built in July 2020, that is strange ...
I have no idea how this could happen, I checked the files from
assembly/target locally and they are the same, January 5th :\ Let me
drop this test build and I will start over.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by James Chaplin <jc...@apache.org>.
Hi Łukasz.
Yes, those are the files I was referring to (the 2.5.23 test distribution zips).
To clarify, my previous post was talking about the zip-entry modification timestamps of everything *inside* the zip files (not the modification timestamp of the zip files themselves).
If you view any of those zip files using a graphical-based zip tool, or unzip one of them, the modification dates of all the contents (all directories, .jar files, etc.) have a January 5th 2020 modification timestamp. For something built in July 2020, that is strange ...
Regards,
James.
On 2020/07/06 06:10:21, Lukasz Lenart <lu...@apache.org> wrote:
> pon., 6 lip 2020 o 05:13 James Chaplin <jc...@apache.org> napisał(a):
> >
> > Hello Łukasz.
> >
> > I started to run through the showcase applications for the 2.5.23 test build, when I noticed something weird in the "struts-2.5.23-all.zip" content timestamps. All of the files/directories within the .zip file seem to have a date/time of "Modified: 2020-01-05 17:24:32 ET" (January 2020). The other .zip file contents seem to show January 2020 timestamps as well, when we would expect them to be in July 2020 instead.
> >
> > Inside the showcase WARs themselves, the struts2-*.jar files themselves have a date/time of "Modified: 2020-07-03 07:57:34 ET", which appears to be correct.
> >
> > Maybe the weird timestamps for the zips from the build are related to the Maven/TLS issues you encountered earlier ? Or maybe there is/was a problem with the system time for the build service infrastructure ?
> >
> > I wanted to let you know so that you can take a look and see if you see the same strange timestamps for the 2.5.23 test build zip contents.
> >
> > If anyone else can confirm the same, please let us know too.
>
> You mean those files here
> https://dist.apache.org/repos/dist/dev/struts/2.5.23/
> ?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
pon., 6 lip 2020 o 05:13 James Chaplin <jc...@apache.org> napisał(a):
>
> Hello Łukasz.
>
> I started to run through the showcase applications for the 2.5.23 test build, when I noticed something weird in the "struts-2.5.23-all.zip" content timestamps. All of the files/directories within the .zip file seem to have a date/time of "Modified: 2020-01-05 17:24:32 ET" (January 2020). The other .zip file contents seem to show January 2020 timestamps as well, when we would expect them to be in July 2020 instead.
>
> Inside the showcase WARs themselves, the struts2-*.jar files themselves have a date/time of "Modified: 2020-07-03 07:57:34 ET", which appears to be correct.
>
> Maybe the weird timestamps for the zips from the build are related to the Maven/TLS issues you encountered earlier ? Or maybe there is/was a problem with the system time for the build service infrastructure ?
>
> I wanted to let you know so that you can take a look and see if you see the same strange timestamps for the 2.5.23 test build zip contents.
>
> If anyone else can confirm the same, please let us know too.
You mean those files here
https://dist.apache.org/repos/dist/dev/struts/2.5.23/
?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.23 test build is ready
Posted by James Chaplin <jc...@apache.org>.
Hello Łukasz.
I started to run through the showcase applications for the 2.5.23 test build, when I noticed something weird in the "struts-2.5.23-all.zip" content timestamps. All of the files/directories within the .zip file seem to have a date/time of "Modified: 2020-01-05 17:24:32 ET" (January 2020). The other .zip file contents seem to show January 2020 timestamps as well, when we would expect them to be in July 2020 instead.
Inside the showcase WARs themselves, the struts2-*.jar files themselves have a date/time of "Modified: 2020-07-03 07:57:34 ET", which appears to be correct.
Maybe the weird timestamps for the zips from the build are related to the Maven/TLS issues you encountered earlier ? Or maybe there is/was a problem with the system time for the build service infrastructure ?
I wanted to let you know so that you can take a look and see if you see the same strange timestamps for the 2.5.23 test build zip contents.
If anyone else can confirm the same, please let us know too.
Regards,
James.
On 2020/07/03 06:18:43, Lukasz Lenart <lu...@apache.org> wrote:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report any problems. I'll call for a vote in a few days if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> https://dist.apache.org/repos/dist/dev/struts/2.5.23/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.23
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org