You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2025/10/05 10:05:08 UTC

svn commit: r1928951 - in pdfbox/branches/3.0/pdfbox/src: main/java/org/apache/pdfbox/multipdf test/java/org/apache/pdfbox/multipdf

Author: tilman
Date: Sun Oct  5 10:05:07 2025
New Revision: 1928951

Log:
PDFBOX-5660: remove unneeded cast, improve javadoc

Modified:
   pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java
   pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFCloneUtilityTest.java

Modified: pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java
==============================================================================
--- pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java	Sun Oct  5 09:55:40 2025	(r1928950)
+++ pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java	Sun Oct  5 10:05:07 2025	(r1928951)
@@ -75,6 +75,7 @@ public class PDFCloneUtility
      * 
      * Expert use only, don’t use it if you don’t know exactly what you are doing.
      * 
+     * @param <TCOSBase> The type to be returned.
      * @param base the initial object as the root of the deep-clone operation
      * @return the cloned instance of the base object
      * @throws IOException if an I/O error occurs

Modified: pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFCloneUtilityTest.java
==============================================================================
--- pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFCloneUtilityTest.java	Sun Oct  5 09:55:40 2025	(r1928950)
+++ pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFCloneUtilityTest.java	Sun Oct  5 10:05:07 2025	(r1928951)
@@ -63,7 +63,7 @@ class PDFCloneUtilityTest
             new PDPageContentStream(srcDoc, pdPage, AppendMode.APPEND, true).close();
             PDFCloneUtility cloner = new PDFCloneUtility(dstDoc);
             assertEquals(dstDoc, cloner.getDestination());
-            COSDictionary clonedPageDictionary = (COSDictionary) cloner.cloneForNewDocument(pdPage.getCOSObject());
+            COSDictionary clonedPageDictionary = cloner.cloneForNewDocument(pdPage.getCOSObject());
             PDPage clonedPage = new PDPage(clonedPageDictionary);
             Iterator<PDStream> contentStreams = clonedPage.getContentStreams();
             assertNotNull(contentStreams.next());