[GitHub] [dubbo] pinxiong commented on a change in pull request #9431: fix: Download zookeeper archive binary in github workflow

[GitBox <gi...@apache.org>]

pinxiong commented on a change in pull request #9431:
URL: https://github.com/apache/dubbo/pull/9431#discussion_r773251647



##########
File path: .github/workflows/build-and-test-3.yml
##########
@@ -65,8 +65,57 @@ jobs:
           echo "::set-output name=version::$REVISION"
           echo "dubbo version: $REVISION"
 
+  unit-test-prepare:
+    name: " Preparation for Unit Test On ${{ matrix.os }} (JDK: ${{ matrix.jdk }})"
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ ubuntu-18.04, windows-2019 ]
+        jdk: [ 8, 11 ]
+    env:
+      DISABLE_FILE_SYSTEM_TEST: true
+    steps:
+      - name: "Set up msys2 if necessary"
+        if: ${{ startsWith( matrix.os, 'windows') }}
+        uses: msys2/setup-msys2@v2
+        with:
+          release: false  # support cache, see https://github.com/msys2/setup-msys2#context
+      - name: "Download zookeeper binary archive in Linux OS"
+        if: ${{ startsWith( matrix.os, 'ubuntu') }}
+        run: |
+          mkdir -p ${{ github.workspace }}/.tmp/zookeeper/
+          wget -c https://archive.apache.org/dist/zookeeper/zookeeper-3.6.3/apache-zookeeper-3.6.3-bin.tar.gz -O ${{ github.workspace }}/.tmp/zookeeper/apache-zookeeper-bin.tar.gz ||

Review comment:
       Thanks for your suggestion! I've fixed it, see #9462 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org