You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/02 12:39:11 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request #11867: Update default values for tuning parameters in kinesis data loader UI
abhishekagarwal87 opened a new pull request #11867:
URL: https://github.com/apache/druid/pull/11867
Follow up PR on https://github.com/apache/druid/pull/11767 to update the data loader UI in the console. Default values used on the druid backend are different from what we see on the kinesis data loader UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11867:
URL: https://github.com/apache/druid/pull/11867#issuecomment-957539887
@abhishekagarwal87 , could you please specify where the default values are defined on the backend?
If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11867:
URL: https://github.com/apache/druid/pull/11867#issuecomment-957539887
@abhishekagarwal87 , could you please specify where the default values are defined on the backend?
If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged pull request #11867:
URL: https://github.com/apache/druid/pull/11867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged pull request #11867:
URL: https://github.com/apache/druid/pull/11867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #11867:
URL: https://github.com/apache/druid/pull/11867#issuecomment-957893675
> @abhishekagarwal87 , could you please specify where the default values are defined on the backend? If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.
That will be a lot of classes to change since console shows the default value for many different tuning configuration classes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #11867:
URL: https://github.com/apache/druid/pull/11867#issuecomment-957893675
> @abhishekagarwal87 , could you please specify where the default values are defined on the backend? If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.
That will be a lot of classes to change since console shows the default value for many different tuning configuration classes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11867:
URL: https://github.com/apache/druid/pull/11867#issuecomment-957539887
@abhishekagarwal87 , could you please specify where the default values are defined on the backend?
If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #11867: Update default values for tuning parameters in kinesis data loader UI
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #11867:
URL: https://github.com/apache/druid/pull/11867#issuecomment-957893675
> @abhishekagarwal87 , could you please specify where the default values are defined on the backend? If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.
That will be a lot of classes to change since console shows the default value for many different tuning configuration classes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org