You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 08:04:27 UTC

[GitHub] [arrow] kou commented on a diff in pull request #12932: ARROW-16248: [C++][FS] Update FileSystemFromUri() docstring for GCS support

kou commented on code in PR #12932:
URL: https://github.com/apache/arrow/pull/12932#discussion_r853845361


##########
cpp/src/arrow/util/config.h.cmake:
##########
@@ -45,6 +45,7 @@
 #cmakedefine ARROW_IPC
 #cmakedefine ARROW_JSON
 
+#cmakedefine ARROW_GCS

Review Comment:
   If we don't have this, `ARROW_GCS` macro isn't defined even when we build Apache Arrow with `-DARROW_GCS=ON`.
   
   If `ARROW_GCS` macro isn't defined, we always get a "Got GCS URI but Arrow compiled without GCS support" error even when we build Apache Arrow with `-DARROW_GCS=ON`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org