[kudu-CR] tool: print usage information when arguments fail to parse

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change.

Change subject: tool: print usage information when arguments fail to parse
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7301/2/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

Line 128:   if (!args_ok && s.IsInvalidArgument()) {
> This seems a little bit redundant; the only way for MarshalArgs to fail is 
k, restructued a bit to make it less convoluted (at the expense of one extra duplicated line)


-- 
To view, visit http://gerrit.cloudera.org:8080/7301
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4695aca5cb3f848f525784476403a9f577fdba13
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes