[PR] fix(databricks): read OSSIE_SQL_2026 metric expressions [ossie]

["christianeu-db (via GitHub)" <gi...@apache.org>]

christianeu-db opened a new pull request, #446:
URL: https://github.com/apache/ossie/pull/446

   ## Summary
   
   #439 added `OSSIE_SQL_2026` to the core spec and #440 added it to the Python
   `OssieDialect` enum. This PR adds awareness to the Databricks converter.
   `pick_expression()` only tried `DATABRICKS` and then `ANSI_SQL`, so a field or
   metric written solely in `OSSIE_SQL_2026` fell through to `None` and got dropped
   from the Metric View.
   
   `OSSIE_SQL_2026` is ANSI-SQL-compatible, so this adds it to the fallback chain:
   
   - `_common.py` gains a `DIALECT_OSSIE_SQL` constant and `pick_expression()` now
     tries `DATABRICKS`, then `ANSI_SQL`, then `OSSIE_SQL_2026`.
   - The two drop warnings in `ossie_to_metric_view.py` mention the new dialect.
   - Three regression tests cover a field-only expression, a metric-only
     expression, and the precedence order when several dialects are present.
   
   `metric_view_to_ossie.py` only ever writes the `DATABRICKS` dialect on the way
   out, so the reverse direction is untouched.
   
   ### On the precedence order
   
   `OSSIE_SQL_2026` is currently last. The Databricks-native dialect should still
   win where it exists, and `ANSI_SQL` is the established fallback. Once more of the
   `OSSIE_SQL_2026` expression-language semantics land as the canonical portable
   form, the plan is to move it to the front of the chain so it becomes the
   preferred source. This PR keeps that a one-line reordering rather than a behavior
   change today.
   
   This is a partial fix. #442 lists five call sites across the converters and
   validation; this one covers the Databricks converter. #443 handles orionbelt.
   
   ## Related Issues
   
   Part of #442.
   
   ## Checklist
   
   Sections that this change does not touch (Specification, Ontology, Validation,
   Documentation, Examples) are left unchecked.
   
   ### Converters
   - [x] Converter logic in `converters/` is updated to reflect spec or ontology changes
   - [x] New converters include tests under the converter's test directory
   
   ### Tests
   - [x] All existing tests pass (`pytest` / CI green)
   - [x] New functionality is covered by tests
   
   ### Compliance
   - [x] ASF license headers are present on all new source files
   - [x] No third-party dependencies are added without PMC/IPMC approval
   
   ---
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(databricks): read OSSIE_SQL_2026 metric expressions [ossie]

["jbonofre (via GitHub)" <gi...@apache.org>]

jbonofre merged PR #446:
URL: https://github.com/apache/ossie/pull/446


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org