[GitHub] [cloudstack] syed opened a new pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

[GitBox <gi...@apache.org>]

syed opened a new pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored 
URL: https://github.com/apache/cloudstack/pull/1906
 
 
   I found this bug when writing a plugin for Baremetal. What happens is that when a host is deleted, it goes through a list of all registered plugins and calls the deleteHost for each plugin. See `ResourceManagerImpl.java:dispatchToStateAdapters` and it stops as soon as someone returns a deleteAnswer. 
   
   Now in case of ODL, it returns a valid answer irrespective of any condition. This causes the other plugins which are supposed to handle this delete request to be skipped. I am returning `null` here so that Cloudstack will continue further and keep calling other agents which can correctly handle the delete request. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services