You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HxpSerein (via GitHub)" <gi...@apache.org> on 2024/11/22 14:20:46 UTC
[PR] [remove datanode] Do not allow regions to inherit the Removing state from datanode [iotdb]
HxpSerein opened a new pull request, #14185:
URL: https://github.com/apache/iotdb/pull/14185
## Description
When removing datanode, datanode status will be updated to Removing and then the region will inherit the datanode status in the heartbeat thread. Not allowing the region to inherit the Removing status can better observe the status of region migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Do not allow regions to inherit the Removing state from datanode [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #14185:
URL: https://github.com/apache/iotdb/pull/14185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Do not allow regions to inherit the Removing state from datanode [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #14185:
URL: https://github.com/apache/iotdb/pull/14185#discussion_r1858136393
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/LoadCache.java:
##########
@@ -306,6 +307,10 @@ public void cacheRegionHeartbeatSample(
.ifPresent(group -> group.cacheHeartbeatSample(nodeId, sample, overwrite));
}
+ public RegionCache getRegionCache(TConsensusGroupId regionGroupId, int nodeId) {
+ return regionGroupCacheMap.get(regionGroupId).getRegionCache(nodeId);
Review Comment:
in case NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Do not allow regions to inherit the Removing state from datanode [iotdb]
Posted by "HxpSerein (via GitHub)" <gi...@apache.org>.
HxpSerein commented on code in PR #14185:
URL: https://github.com/apache/iotdb/pull/14185#discussion_r1858480339
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/LoadCache.java:
##########
@@ -306,6 +307,10 @@ public void cacheRegionHeartbeatSample(
.ifPresent(group -> group.cacheHeartbeatSample(nodeId, sample, overwrite));
}
+ public RegionCache getRegionCache(TConsensusGroupId regionGroupId, int nodeId) {
+ return regionGroupCacheMap.get(regionGroupId).getRegionCache(nodeId);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org