You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/25 11:29:20 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #2400: Syslog format, variable name errors, nxstyle fixes

yamt opened a new pull request #2400:
URL: https://github.com/apache/incubator-nuttx/pull/2400


   ## Summary
   Extracted from https://github.com/apache/incubator-nuttx/pull/2347
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2400: Syslog format, variable name errors, nxstyle fixes

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2400:
URL: https://github.com/apache/incubator-nuttx/pull/2400


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #2400: Syslog format, variable name errors, nxstyle fixes

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2400:
URL: https://github.com/apache/incubator-nuttx/pull/2400#issuecomment-733650813


   The following nxstyle errors are intentionally left
   because they are parts of the copyright notices.
   
   ```
   fs/nfs/rpc_clnt.c:46:80: error: Long line found
   fs/nfs/rpc_clnt.c:63:78: error: Long line found
   ```
   
   The following nxstyle errors are not new.
   (macros like SIZEOF_rpc_reply_readdir)
   
   ```
   fs/nfs/nfs_vfsops.c:848:12: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1020:16: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1420:13: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1818:11: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1819:11: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1830:8: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1851:42: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:2049:54: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:2115:58: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:2172:54: error: Mixed case identifier found
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt edited a comment on pull request #2400: Syslog format, variable name errors, nxstyle fixes

Posted by GitBox <gi...@apache.org>.
yamt edited a comment on pull request #2400:
URL: https://github.com/apache/incubator-nuttx/pull/2400#issuecomment-733650813


   The following nxstyle error is a false positive.
   https://github.com/apache/incubator-nuttx/issues/387
   
   ```
   fs/nfs/nfs_util.c:70:39: error: C++ style comment
   ```
   
   The following nxstyle errors are intentionally left
   because they are parts of the copyright notices.
   
   ```
   fs/nfs/rpc_clnt.c:46:80: error: Long line found
   fs/nfs/rpc_clnt.c:63:78: error: Long line found
   ```
   
   The following nxstyle errors are not new.
   (macros like SIZEOF_rpc_reply_readdir)
   
   ```
   fs/nfs/nfs_vfsops.c:848:12: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1020:16: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1420:13: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1818:11: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1819:11: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1830:8: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:1851:42: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:2049:54: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:2115:58: error: Mixed case identifier found
   fs/nfs/nfs_vfsops.c:2172:54: error: Mixed case identifier found
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org