You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2021/01/26 16:34:00 UTC
[jira] [Commented] (IGNITE-13588) .NET: Incorrect binary type name
is registered for generic query types
[ https://issues.apache.org/jira/browse/IGNITE-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272218#comment-17272218 ]
Ignite TC Bot commented on IGNITE-13588:
----------------------------------------
{panel:title=Branch: [pull/8708/head] Base: [master] : Possible Blockers (7)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Control Utility{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5844074]]
{color:#d04437}Java Client{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5843999]]
{color:#d04437}Basic 1{color} [[tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5844020]]
{color:#d04437}Cache 1{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5844036]]
{color:#d04437}Compute (Grid){color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5843989]]
{color:#d04437}Platform .NET{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5844055]]
* exe: IgniteLockTests.TestFairLockGuaranteesOrder - Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}PDS 3{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5844053]]
* IgnitePdsTestSuite3: IgnitePdsContinuousRestartTestWithExpiryPolicy.testRebalancingDuringLoad_8000_500_8_1 - Test has low fail rate in base branch 0,0% and is not flaky
{panel}
{panel:title=Branch: [pull/8708/head] Base: [master] : New Tests (52)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Thin client: Python{color} [[tests 48|https://ci.ignite.apache.org/viewLog.html?buildId=5844079]]
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value45-None] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value46-None] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value43-ObjectArrayObject] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value44-None] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-True-None-None-.opt.buildagent.work.425d7af4e9aa99d9.ignite-python-thin-client.tests.config.ssl.client_full_pem-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value24-BoolArrayObject] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-True-None-None-.opt.buildagent.work.425d7af4e9aa99d9.ignite-python-thin-client.tests.config.ssl.client_full_pem-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value28-None] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-True-None-None-.opt.buildagent.work.425d7af4e9aa99d9.ignite-python-thin-client.tests.config.ssl.client_full_pem-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value22-BoolArrayObject] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-True-None-None-.opt.buildagent.work.425d7af4e9aa99d9.ignite-python-thin-client.tests.config.ssl.client_full_pem-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value23-BoolArrayObject] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value33-BinaryEnumObject] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value38-None] - PASSED{color}
* {color:#013220}tests.test_datatypes.test_put_get_data[node0-None-False-False-None-None-None-None-VerifyMode_CERT_NONE-DEFAULT:!aNULL:!eNULL:!MD5:!3DES:!DES:!RC4:!IDEA:!SEED:!aDSS:!SRP:!PSK-_SSLMethod_PROTOCOL_TLSv1_1-None-None-value30-None] - PASSED{color}
... and 37 new tests
{color:#00008b}Platform .NET (Core Linux){color} [[tests 2|https://ci.ignite.apache.org/viewLog.html?buildId=5844056]]
* {color:#013220}dll: CacheQueriesCodeConfigurationTest.TestNestedGenericQueryTypes - PASSED{color}
* {color:#013220}dll: CacheQueriesCodeConfigurationTest.TestGenericQueryTypes - PASSED{color}
{color:#00008b}Platform .NET{color} [[tests 2|https://ci.ignite.apache.org/viewLog.html?buildId=5844055]]
* {color:#013220}exe: CacheQueriesCodeConfigurationTest.TestGenericQueryTypes - PASSED{color}
* {color:#013220}exe: CacheQueriesCodeConfigurationTest.TestNestedGenericQueryTypes - PASSED{color}
{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5844080&buildTypeId=IgniteTests24Java8_RunAll]
> .NET: Incorrect binary type name is registered for generic query types
> ----------------------------------------------------------------------
>
> Key: IGNITE-13588
> URL: https://issues.apache.org/jira/browse/IGNITE-13588
> Project: Ignite
> Issue Type: Bug
> Components: platforms
> Affects Versions: 2.9, 2.8.1
> Environment: Apache Ignite: v2.8.1
> JDK: v1.8
> .NET Core: v3.1
> Reporter: Danut Radoaica
> Assignee: Pavel Tupitsyn
> Priority: Major
> Labels: .NET, 2.9.1-rc
> Attachments: Untitled.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Using a generic type as a QueryEntity value type results in a wrong type name being registered in QueryEntities and a wrong typeId being calculated for the binary metadata:
> {code}
> var ignite = Ignition.Start(TestUtils.GetTestConfiguration());
> var cfg = new CacheConfiguration(TestUtils.TestName)
> {
> QueryEntities = new[] {new QueryEntity(typeof(int), typeof(GenericTest<string>))}
> };
> var cache = ignite.GetOrCreateCache<int, GenericTest<string>>(cfg);
> cache[1] = new GenericTest<string> {Prop = "foo"};
> var binType = ignite.GetBinary().GetBinaryTypes().Single();
> Assert.AreEqual(-590542188, binType.TypeId); // 945954881 with QueryEntity
> Assert.AreEqual(
> "Apache.Ignite.Core.Tests.Cache.Query.CacheQueriesCodeConfigurationTest+GenericTest`1[[System.String]]",
> cache.GetConfiguration().QueryEntities.Single().ValueTypeName); // Includes assembly name with query entity
> {code}
> {{BinaryUtils.GetSqlTypeName}} returns Type.FullName, which includes assembly-qualified type names for all generic type arguments.
> This causes the following problems:
> * SQL type name includes assembly versions, so queries stop working if there is a version change
> * Incorrect binary type id is registered, because due to IGNITE-13160 changes the string from {{BinaryUtils.GetSqlTypeName}} gets passed back to {{UnmanagedCallbacks.BinaryTypeGet}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)