[GitHub] [spark] zsxwing commented on a change in pull request #28758: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing (branch-2.4)

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #28758:
URL: https://github.com/apache/spark/pull/28758#discussion_r436988149



##########
File path: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
##########
@@ -485,29 +483,6 @@ class JsonProtocolSuite extends SparkFunSuite {
       value = Some(Set("foo")),
       expectedValue = None)
   }
-
-  test("SPARK-30936: forwards compatibility - ignore unknown fields") {

Review comment:
       These two tests are not in branch-2.4, which causes the conflicts.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org