You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/30 04:47:39 UTC
[GitHub] [doris] SaintBacchus opened a new pull request, #13786: [feature-wip][MTMV] Add show statement for MTMV
SaintBacchus opened a new pull request, #13786:
URL: https://github.com/apache/doris/pull/13786
# Proposed changes
Issue Number: close #13751
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #13786: [feature-wip](MTMV)Add show statement for MTMV
Posted by GitBox <gi...@apache.org>.
adonis0147 merged PR #13786:
URL: https://github.com/apache/doris/pull/13786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13786: [feature-wip](MTMV)Add show statement for MTMV
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13786:
URL: https://github.com/apache/doris/pull/13786#issuecomment-1311161533
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13786: [feature-wip](MTMV)Add show statement for MTMV
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13786:
URL: https://github.com/apache/doris/pull/13786#issuecomment-1313127024
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13786: [feature-wip][MTMV] Add show statement for MTMV
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13786:
URL: https://github.com/apache/doris/pull/13786#issuecomment-1296331022
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.41 seconds
load time: 557 seconds
storage size: 17154739689 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221030191655_clickbench_pr_35886.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13786: [feature-wip](MTMV)Add show statement for MTMV
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13786:
URL: https://github.com/apache/doris/pull/13786#issuecomment-1311161555
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13786: [feature-wip](MTMV)Add show statement for MTMV
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13786:
URL: https://github.com/apache/doris/pull/13786#discussion_r1020757418
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1796,7 +1796,10 @@ public class Config extends ConfigBase {
public static int max_pending_mtmv_scheduler_task_num = 100;
@ConfField(mutable = true, masterOnly = true)
- public static long scheduler_mtmv_task_expire_ms = 24 * 60 * 60 * 1000L; // 1day
+ public static long scheduler_mtmv_job_expired = 24 * 60 * 60L; // 1day
+
+ @ConfField(mutable = true, masterOnly = true)
Review Comment:
Please add some comment in code for these configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org