You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2014/12/14 17:07:00 UTC

wicket git commit: Moved Wicket 8 todos aout of JavaDoc sections.

Repository: wicket
Updated Branches:
  refs/heads/master 214e178c0 -> b6f3a605d


Moved Wicket 8 todos aout of JavaDoc sections.

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b6f3a605
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b6f3a605
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b6f3a605

Branch: refs/heads/master
Commit: b6f3a605d1e8a0c57e63565479cefd105877056a
Parents: 214e178
Author: Andrea Del Bene <ad...@apache.org>
Authored: Sun Dec 14 17:05:02 2014 +0100
Committer: Andrea Del Bene <ad...@apache.org>
Committed: Sun Dec 14 17:05:02 2014 +0100

----------------------------------------------------------------------
 .../main/java/org/apache/wicket/util/IProvider.java  |  8 +++++---
 .../java/org/apache/wicket/util/crypt/Base64.java    |  6 +++---
 .../java/org/apache/wicket/util/string/Strings.java  | 15 ++++++++-------
 3 files changed, 16 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/b6f3a605/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
index 67822e5..8bc0c7d 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
@@ -19,9 +19,6 @@ package org.apache.wicket.util;
 /**
  * An object that can provide instances of type {@code T}
  * 
- * TODO Wicket 8: consider to deprecate this interface in Wicket 7 and replace it with standard 
- * Java 8 {@code java.util.function.Supplier<T>} which is virtually identical.
- * 
  * @author igor.vaynberg
  * @param <T>
  */
@@ -33,4 +30,9 @@ public interface IProvider<T>
 	 * @return instance of type {@code T}
 	 */
 	T get();
+	
+	/** 
+	 * TODO Wicket 8: consider to deprecate this interface in Wicket 7 and replace it with standard 
+     * Java 8 {@code java.util.function.Supplier<T>} which is virtually identical.
+	 * */
 }

http://git-wip-us.apache.org/repos/asf/wicket/blob/b6f3a605/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
index d8b5dcc..4d2388a 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
@@ -34,8 +34,6 @@ import java.math.BigInteger;
  * Josefsson.
  * </p>
  * 
- * TODO Wicket 8: consider to deprecate this class in Wicket 7 and replace it with standard Java 8 {@code java.util.Base64}
- * 
  * @author Apache Software Foundation
  * @author Juergen Donnerstag
  * 
@@ -43,10 +41,12 @@ import java.math.BigInteger;
  */
 public class Base64
 {
+    //* TODO Wicket 8: consider to deprecate this class in Wicket 7 and replace it with standard Java 8 {@code java.util.Base64}
+	
 	private static final int DEFAULT_BUFFER_RESIZE_FACTOR = 2;
 
 	private static final int DEFAULT_BUFFER_SIZE = 8192;
-
+	
 	/**
 	 * Chunk size per RFC 2045 section 6.8.
 	 * 

http://git-wip-us.apache.org/repos/asf/wicket/blob/b6f3a605/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
index ac9707b..103f6b0 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
@@ -51,6 +51,13 @@ import org.apache.wicket.util.lang.Args;
  */
 public final class Strings
 {
+	/** 
+	 * TODO Wicket 8: consider to deprecate methods {@code join} in Wicket 7 and replace it with standard 
+	 * Java 8 methods {@code String#join(CharSequence delimiter, CharSequence... elements)} 
+	 * and {@code String#join(CharSequence delimiter, Iterable<? extends CharSequence> elements)}
+	 *
+	 * */
+	
 	/**
 	 * The line separator for the current platform.
 	 */
@@ -629,13 +636,10 @@ public final class Strings
 	/**
 	 * Joins string fragments using the specified separator
 	 * 
-	 * TODO Wicket 8: consider to deprecate this method in Wicket 7 and replace it with standard 
-	 * Java 8 {@code String#join(CharSequence delimiter, Iterable<? extends CharSequence> elements)} 
-	 * 
 	 * @param separator
 	 * @param fragments
 	 * @return combined fragments
-	 */
+     */
 	public static String join(final String separator, final List<String> fragments)
 	{
 		if (fragments == null)
@@ -649,9 +653,6 @@ public final class Strings
 	/**
 	 * Joins string fragments using the specified separator
 	 * 
-	 * TODO Wicket 8: consider to deprecate this method in Wicket 7 and replace it with standard 
-	 * Java 8 {@code String#join(CharSequence delimiter, CharSequence... elements)}
-	 * 
 	 * @param separator
 	 * @param fragments
 	 * @return combined fragments