You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2021/06/03 00:12:30 UTC
[commons-numbers] branch master updated: Reinstate "CheckStyle"
global rule, disable it on a per-file basis.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
The following commit(s) were added to refs/heads/master by this push:
new ecf428e Reinstate "CheckStyle" global rule, disable it on a per-file basis.
ecf428e is described below
commit ecf428e1991fb53996e77829aa22641b543ad12d
Author: Gilles Sadowski <gi...@gmail.com>
AuthorDate: Thu Jun 3 02:11:18 2021 +0200
Reinstate "CheckStyle" global rule, disable it on a per-file basis.
---
src/main/resources/checkstyle/checkstyle-suppressions.xml | 2 ++
src/main/resources/checkstyle/checkstyle.xml | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/main/resources/checkstyle/checkstyle-suppressions.xml b/src/main/resources/checkstyle/checkstyle-suppressions.xml
index d50f34a..26e5e11 100644
--- a/src/main/resources/checkstyle/checkstyle-suppressions.xml
+++ b/src/main/resources/checkstyle/checkstyle-suppressions.xml
@@ -24,6 +24,8 @@
<suppress checks="FileLengthCheck" files=".*[/\\]Complex(Test)?\.java" />
<suppress checks="FileLengthCheck" files=".*jmh[/\\]arrays[/\\]LinearCombinations.java" />
<suppress checks="MethodLength" files=".*[/\\]Complex\.java" />
+ <!-- Method "hashCode()" is defined in the "Angle" parent class; subclasses have no additional fields to include in the hash. -->
+ <suppress checks="EqualsHashCode" files=".*[/\\]Angle\.java" />
<!-- Be more lenient on tests. -->
<suppress checks="Javadoc" files=".*[/\\]test[/\\].*" />
diff --git a/src/main/resources/checkstyle/checkstyle.xml b/src/main/resources/checkstyle/checkstyle.xml
index 88725ad..23d566a 100644
--- a/src/main/resources/checkstyle/checkstyle.xml
+++ b/src/main/resources/checkstyle/checkstyle.xml
@@ -157,7 +157,7 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sourceforge.net/config_coding.html -->
<module name="EmptyStatement" />
- <!-- <module name="EqualsHashCode" /> -->
+ <module name="EqualsHashCode" />
<!-- Method parameters and local variables should not hide fields, except in constructors and setters -->
<module name="HiddenField">
<property name="ignoreConstructorParameter" value="true" />