Re: [PR] fix(ingest): Repair affected logical timestamp milli tables [hudi]

["yihua (via GitHub)" <gi...@apache.org>]

yihua commented on code in PR #14161:
URL: https://github.com/apache/hudi/pull/14161#discussion_r2488424380


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedFileFormat.scala:
##########
@@ -87,6 +88,14 @@ class HoodieFileGroupReaderBasedFileFormat(tablePath: String,
 
   private lazy val avroTableSchema = new Schema.Parser().parse(tableSchema.avroSchemaStr)
 
+  private lazy val tableSchemaAsMessageType: org.apache.hudi.common.util.Option[org.apache.parquet.schema.MessageType] = {
+    org.apache.hudi.common.util.Option.ofNullable(
+      ParquetTableSchemaResolver.convertAvroSchemaToParquet(avroTableSchema, new Configuration())
+    )
+  }
+
+  private lazy val supportBatchTimestampRepair = HoodieSparkUtils.gteqSpark3_5 || !AvroSchemaRepair.hasTimestampMillisField(avroTableSchema)

Review Comment:
   Ah, got it.  Make sense now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org