You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/14 09:14:55 UTC

[GitHub] [cloudstack] mib1185 opened a new pull request #5206: UI: only display host information, if they are relevant

mib1185 opened a new pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206


   ### Description
   
   This PR improves the HostView, so that only relevant information are shown.
   This also fixes a small bug, when no `hosttags` or `oscategoryid` exists, that wrong (_maybe cached?_) values were shown, instead of no values.
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r672218547



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       Don't think this should be changed so that the user can explicitly see whether ha is enabled or not




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r672252567



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       the `host.hostha.haenable` state is already  shown above, so the `host.hostha.hastate` should only be relevant, if `haenable` is True




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-879734131


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r672252567



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       the `host.hostha.haenable` state is already  shown above, so the `host.hostha.hastate` should only be relevant, if `haenable` is True




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-879737368


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5206 (SL-JID-357)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-882508656


   > @mib1185 can you add test info/screen shots before/after?
   > cltgm
   
   @DaanHoogland I'm sorry, but I'm on vacation the next three weeks and those do not have access to our environment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r672218547



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       Don't think this should be changed so that the user can explicitly see whether ha is enabled or not




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-881232193


   @mib1185 can you add test info/screen shots before/after?
   cltgm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-882508656


   > @mib1185 can you add test info/screen shots before/after?
   > cltgm
   
   @DaanHoogland I'm sorry, but I'm on vacation the next three weeks and those do not have access to our environment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r672218547



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       Don't think this should be changed so that the user can explicitly see whether ha is enabled or not




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-879734719


   @mib1185 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#issuecomment-882508656


   > @mib1185 can you add test info/screen shots before/after?
   > cltgm
   
   @DaanHoogland I'm sorry, but I'm on vacation the next three weeks and those do not have access to our environment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r675292125



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       Ah yes, my bad




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] mib1185 commented on a change in pull request #5206: UI: only display host information, if they are relevant

Posted by GitBox <gi...@apache.org>.
mib1185 commented on a change in pull request #5206:
URL: https://github.com/apache/cloudstack/pull/5206#discussion_r672252567



##########
File path: ui/src/views/infra/HostInfo.vue
##########
@@ -83,15 +83,15 @@
           </div>
         </div>
       </a-list-item>
-      <a-list-item v-if="host.hostha">
+      <a-list-item v-if="host.hostha && host.hostha.haenable">

Review comment:
       the `host.hostha.haenable` state is already  shown above, so the `host.hostha.hastate` should only be relevant, if `haenable` is True




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org