You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (Created) (JIRA)" <ji...@apache.org> on 2011/12/15 09:32:30 UTC
[jira] [Created] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
------------------------------------------------------------------------------------
Key: CAMEL-4782
URL: https://issues.apache.org/jira/browse/CAMEL-4782
Project: Camel
Issue Type: Improvement
Components: camel-core, jmx
Reporter: Claus Ibsen
Priority: Minor
Fix For: 2.9.1, 2.10
It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
Then you can see this from management tooling or jconsole etc.
People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat reassigned CAMEL-4782:
-----------------------------------
Assignee: Babak Vahdat
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178026#comment-13178026 ]
Babak Vahdat commented on CAMEL-4782:
-------------------------------------
Claus,
What do you think about this second approach?
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat resolved CAMEL-4782.
---------------------------------
Resolution: Fixed
Applied my provided second patch (attached to this ticket) both into the trunk as well as 2.9.x branch.
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10.0
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179542#comment-13179542 ]
Claus Ibsen commented on CAMEL-4782:
------------------------------------
I have been busy today tracking down a leak.
I suggest to post a mail on @dev as we may look for more feedback for a good way to store EIP statistics and how to expose those from JMX and in the future REST management APIs.
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: CAMEL-4782-2.patch
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: (was: CAMEL-4782-2.patch)
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179369#comment-13179369 ]
Babak Vahdat commented on CAMEL-4782:
-------------------------------------
Claus,
What do you think about this second approach?
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216734#comment-13216734 ]
Babak Vahdat commented on CAMEL-4782:
-------------------------------------
Didn't get much of feedback I was looking for @dev. However the *second* patch provided seems reasonable to me.
Do you agree on applying it?
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10.0
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: CAMEL-4782.patch
Attached a new copy of the provided patch with some more code-polishment.
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: (was: CAMEL-4782-2.patch)
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171928#comment-13171928 ]
Babak Vahdat commented on CAMEL-4782:
-------------------------------------
Attached a potential patch for review (including unit-test). Please let me know if it's the way you would go for it or do you think of some other approaches. With [1] as the newest revision on the trunk, following the test results on camel-core:
Results :
Tests run: 3978, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-bundle-plugin:2.3.4:bundle (default-bundle) @ camel-core ---
[WARNING] Warning building bundle org.apache.camel:camel-core:bundle:2.10-SNAPSHOT : Did not find matching referal for !org.apache.camel.*
[INFO]
[INFO] --- maven-shade-plugin:1.4:shade (default) @ camel-core ---
[INFO] Including com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:jar:1.2 in the shaded jar.
[INFO] Excluding org.slf4j:slf4j-api:jar:1.6.1 from the shaded jar.
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing c:\dev\workspace\camel\camel-core\target\camel-core-2.10-SNAPSHOT.jar with c:\dev\workspace\camel\camel-core\target\camel-core-2.10-SNAPSHOT-sh
aded.jar
[INFO]
[INFO] --- maven-jar-plugin:2.2:test-jar (default) @ camel-core ---
[INFO] Building jar: c:\dev\workspace\camel\camel-core\target\camel-core-2.10-SNAPSHOT-tests.jar
[INFO]
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ camel-core ---
[INFO] Checking legal files in: camel-core-2.10-SNAPSHOT.jar
[INFO] Checking legal files in: camel-core-2.10-SNAPSHOT-tests.jar
[INFO]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ camel-core ---
[INFO] Installing c:\dev\workspace\camel\camel-core\target\camel-core-2.10-SNAPSHOT.jar to C:\Users\Babak\.m2\repository\org\apache\camel\camel-core\2.10-SNAPSH
OT\camel-core-2.10-SNAPSHOT.jar
[INFO] Installing c:\dev\workspace\camel\camel-core\dependency-reduced-pom.xml to C:\Users\Babak\.m2\repository\org\apache\camel\camel-core\2.10-SNAPSHOT\camel-
core-2.10-SNAPSHOT.pom
[INFO] Installing c:\dev\workspace\camel\camel-core\target\camel-core-2.10-SNAPSHOT-tests.jar to C:\Users\Babak\.m2\repository\org\apache\camel\camel-core\2.10-
SNAPSHOT\camel-core-2.10-SNAPSHOT-tests.jar
[INFO]
[INFO] --- maven-bundle-plugin:2.3.4:install (default-install) @ camel-core ---
[INFO] Installing org/apache/camel/camel-core/2.10-SNAPSHOT/camel-core-2.10-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:31.083s
[INFO] Finished at: Sun Dec 18 19:24:16 CET 2011
[INFO] Final Memory: 27M/494M
[INFO] ------------------------------------------------------------------------
[1] http://svn.apache.org/viewvc?view=revision&revision=1220370
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: CAMEL-4782.patch
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: (was: CAMEL-4782.patch)
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174395#comment-13174395 ]
Babak Vahdat commented on CAMEL-4782:
-------------------------------------
O.K. I did the way of your proposal and indeed that seems much better to me as well (see the second patch). But now as you see, we've got a trade-off situation here, that's we still keep counting the duplicate message count even if JMX is disabled! However we may want to argue that in the future there'll be probably API clients other than JMX who may want to make usage of the provided getDuplicateMessageCount() & resetDuplicateMessageCount() API offered *directly* by the IdempotentConsumer EIP processor.
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: CAMEL-4782-2.patch
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174151#comment-13174151 ]
Claus Ibsen commented on CAMEL-4782:
------------------------------------
Yeah the runnable is the poor mans closure.
I wonder if we should just keep the stats in the EIP processors directly, and the from the mbean, invoke the getXXX method from the processor?
The performance stats however is kept in the PerformanceMBean. So I understand that keeping stats in the MBean to make it similar.
Lets ponder a bit about this.
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216754#comment-13216754 ]
Claus Ibsen commented on CAMEL-4782:
------------------------------------
Yeah the 2nd patch is nicer.
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10.0
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180500#comment-13180500 ]
Babak Vahdat commented on CAMEL-4782:
-------------------------------------
I put the question for further discussion [1] onto the @dev.
[1] http://camel.465427.n5.nabble.com/DISCUSS-How-to-better-enlist-the-duplicate-message-count-by-the-IdempotentConsumer-on-JMX-td5123118.html
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4782) Add ManagedIdempotentConsumerBean
with additional details such as duplicate detected
Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Babak Vahdat updated CAMEL-4782:
--------------------------------
Attachment: CAMEL-4782-2.patch
> Add ManagedIdempotentConsumerBean with additional details such as duplicate detected
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-4782
> URL: https://issues.apache.org/jira/browse/CAMEL-4782
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, jmx
> Reporter: Claus Ibsen
> Assignee: Babak Vahdat
> Priority: Minor
> Fix For: 2.9.1, 2.10
>
> Attachments: CAMEL-4782-2.patch, CAMEL-4782.patch
>
>
> It would be nice if this EIP had a specialized MBean which has details about number of duplicate detected.
> Then you can see this from management tooling or jconsole etc.
> People may use this EIP as a sort of fail safe to detect and discard duplicates. So it would be nice if we have stats in JMX we can expose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira