You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/12 08:19:38 UTC

[GitHub] mhenke1 opened a new pull request #3752: Move uuid into namespace to decouple it from authkey

mhenke1 opened a new pull request #3752: Move uuid into namespace to decouple it from authkey
URL: https://github.com/apache/incubator-openwhisk/pull/3752
 
 
   This PR makes the uuid an explicit part of a namespace  object containing name and uuid of a namespace.
   
   ## Description
   In many places the uuid stored in the authkey is now used as the unique way to identify
   a namespace. This behavior entangles the authorization mechanisms
   with other unrelated parts of the code, making changes and extensions of the authentication mechanism unnecessarily hard.
   
   This PR makes the uuid a member of a new namespace object containing the name and the
   uuid of the namespace. All references to the uuid that are not used on the context of authorization are using the new namespace object as source.
   
   [PG3:2227 succeeded]
   
   ## Related issue and scope
   N/A
   
   ## My changes affect the following components>
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services