You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/02 17:50:23 UTC

[GitHub] [beam] lukecwik commented on pull request #22144: Tune ByteStringCoder allocations

lukecwik commented on PR #22144:
URL: https://github.com/apache/beam/pull/22144#issuecomment-1172935753

   No worries Steve. These are very useful improvements for all pipelines.
   
   It seems as though ByteString.readFrom honors the size we pass in so it only creates one chunk, but then it copies the bytes again (for immutability purposes): https://github.com/protocolbuffers/protobuf/blob/7a07be5ad5e5dfe5af65f8101e99fec9604d15e5/java/core/src/main/java/com/google/protobuf/ByteString.java#L595


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org