You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:43:53 UTC
[GitHub] [incubator-doris] yinzhijian opened a new pull request, #9546: [Fix](migrate) ignore unnecessary error printing
yinzhijian opened a new pull request, #9546:
URL: https://github.com/apache/incubator-doris/pull/9546
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
W0513 14:47:57.078735 16965 status.h:514] warning: Status msg truncated, Internal error: precise_code:-2 0# doris::Status::ConstructErrorStatus(short, doris::Slice const&) at /home/disk4/yintao03/baidu/bdg/doris/core/be/src/common/status.cpp:81
1# doris::Status::OLAPInternalError(short) at /home/disk4/yintao03/baidu/bdg/doris/core/be/src/common/status.h:385
2# doris::TaskWorkerPool::_check_migrate_request(doris::TStorageMediumMigrateReq const&, std::shared_ptr<doris::Tablet>&, doris::DataDir**) at /home/disk4/yintao03/baidu/bdg/doris/core/be/src/agent/task_worker_pool.cpp:1013
3# doris::TaskWorkerPool::_storage_medium_migrate_worker_thread_callback() at /home/disk4/yintao03/baidu/bdg/doris/core/be/src/agent/task_worker_pool.cpp:935
4# void std::__invoke_impl<void, void (doris::TaskWorkerPool::*&)(), doris::TaskWorkerPool*&>(std::__invoke_memfun_deref, void (doris::TaskWorkerPool::*&)(), doris::TaskWorkerPool*&) at /home/disk4/yintao03/baidu/bdg/doris/palo-toolchain/ldb_toolchain/include/c++/11/bits/invoke.h:74
5# std::enable_if<is_invocable_r_v<void, void (doris::TaskWorkerPool::*&)(), doris::TaskWorkerPool*&>, void>::type std::__invoke_r<void, void (doris::TaskWorkerPool::*&)(), doris::TaskWorkerPool*&>(void (doris::TaskWorkerPool::*&)(), doris::TaskWorkerPool*&) at /home/disk4/yintao03/baidu/bdg/doris/palo-toolchain/ldb_toolchain/include/c++/11/bits/invoke.h:117
6# void std::_Bind_result<void, void (doris::TaskWorkerPool::*(doris::TaskWorkerPool*))()>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) at /home/disk4/yintao03/baidu/bdg/doris/palo-toolchain/ldb_toolchain/include/c++/11/functional:571
7# void std::_Bind_result<void, void (doris::TaskWorkerPool::*(doris::TaskWorkerPool*))()>::operator()<>() at /home/disk4/yintao03/baidu/bdg/doris/palo-toolchain/ldb_toolchain/include/c++/11/functional:631
8# void std::__invoke_impl<void, std::_Bind_result<void, void (doris::TaskWorkerPool::*(doris::TaskWorkerPool*))()>&>(std::__invoke_other, std::_Bind_result<void, void (doris::TaskWorkerPool::*(doris::TaskWorkerPool*))()>&) at /home/disk4/yintao03/baidu/bdg/doris/palo-toolchain/ldb_toolchain/include/c++/11/bits/invoke.h:61
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yinzhijian closed pull request #9546: [Fix](migrate) ignore unnecessary error printing
Posted by GitBox <gi...@apache.org>.
yinzhijian closed pull request #9546: [Fix](migrate) ignore unnecessary error printing
URL: https://github.com/apache/incubator-doris/pull/9546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9546: [Fix](migrate) ignore unnecessary error printing
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #9546:
URL: https://github.com/apache/incubator-doris/pull/9546#discussion_r872103706
##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -1010,7 +1010,8 @@ Status TaskWorkerPool::_check_migrate_request(const TStorageMediumMigrateReq& re
if (tablet->data_dir()->path() == (*dest_store)->path()) {
LOG(INFO) << "tablet is already on specified path. "
<< "path=" << tablet->data_dir()->path();
- return Status::OLAPInternalError(OLAP_REQUEST_FAILED);
Review Comment:
line 999 has the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org