You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2018/06/18 05:09:25 UTC

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope 

Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10746


Change subject: IMPALA-7150: fixes jni frame scope
......................................................................

IMPALA-7150: fixes jni frame scope

A previous change (https://gerrit.cloudera.org/#/c/9968/)
reduced the time that a lib-cache entry was held when initializing
a udf. It did so by introducing a new scope. However, that scope
captured a jni frame, which resulted in an earlier frame pop
than before. This change decouples the frame scope from the lib-cache
scope so that the frame is popped at the end of the method (as before)
instread of with the lib-cache scope.

Testing:
- core, asan tests pass

Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
---
M be/src/exprs/hive-udf-call.cc
1 file changed, 7 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/10746/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2716/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 18:08:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 17:41:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 21:33:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 18:08:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 2:

No worries, we can continue to monitor builds since we do reproduce at some rate there.


-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 17:41:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 1:

(1 comment)

I have not been able to repro-- this particular issue has been rare as far as I've seen. Instead, given the cores and prev. change, I've treated this more as a revert to prev. memory behavior.

http://gerrit.cloudera.org:8080/#/c/10746/1/be/src/exprs/hive-udf-call.cc
File be/src/exprs/hive-udf-call.cc:

http://gerrit.cloudera.org:8080/#/c/10746/1/be/src/exprs/hive-udf-call.cc@202
PS1, Line 202:   
> trailing whitespace.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 17:01:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................


Patch Set 1:

(1 comment)

The change seems safe and the theory makes sense. Were you able to reproduce the crash reliably enough to confirm that this fixed it?

http://gerrit.cloudera.org:8080/#/c/10746/1/be/src/exprs/hive-udf-call.cc
File be/src/exprs/hive-udf-call.cc:

http://gerrit.cloudera.org:8080/#/c/10746/1/be/src/exprs/hive-udf-call.cc@202
PS1, Line 202:   
trailing whitespace.



-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jun 2018 15:57:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10746 )

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................

IMPALA-7150: fixes jni frame scope

A previous change (https://gerrit.cloudera.org/#/c/9968/)
reduced the time that a lib-cache entry was held when initializing
a udf. It did so by introducing a new scope. However, that scope
captured a jni frame, which resulted in an earlier frame pop
than before. This change decouples the frame scope from the lib-cache
scope so that the frame is popped at the end of the method (as before)
instread of with the lib-cache scope.

Testing:
- core, asan tests pass

Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Reviewed-on: http://gerrit.cloudera.org:8080/10746
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/hive-udf-call.cc
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 4
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10746

to look at the new patch set (#2).

Change subject: IMPALA-7150: fixes jni frame scope
......................................................................

IMPALA-7150: fixes jni frame scope

A previous change (https://gerrit.cloudera.org/#/c/9968/)
reduced the time that a lib-cache entry was held when initializing
a udf. It did so by introducing a new scope. However, that scope
captured a jni frame, which resulted in an earlier frame pop
than before. This change decouples the frame scope from the lib-cache
scope so that the frame is popped at the end of the method (as before)
instread of with the lib-cache scope.

Testing:
- core, asan tests pass

Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
---
M be/src/exprs/hive-udf-call.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/10746/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>