You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/27 14:28:17 UTC
[GitHub] [apisix] Baoyuantop opened a new pull request #6219: docs: optimizing api-breaker documentation
Baoyuantop opened a new pull request #6219:
URL: https://github.com/apache/apisix/pull/6219
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
resolve https://github.com/apache/apisix/issues/6175
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6219: docs: optimizing api-breaker documentation
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6219:
URL: https://github.com/apache/apisix/pull/6219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6219: docs: optimizing api-breaker documentation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6219:
URL: https://github.com/apache/apisix/pull/6219#discussion_r794159919
##########
File path: docs/en/latest/plugins/api-breaker.md
##########
@@ -90,7 +95,7 @@ curl "http://127.0.0.1:9080/apisix/admin/routes/1" -H 'X-API-KEY: edd1c9f034335f
Then. Like the configuration above, if your upstream service returns 500. 3 times in a row. The client will receive a 502 (break_response_code) response.
```shell
-$ curl -i -X POST "http://127.0.0.1:9080/get"
+$ curl -i -X POST "http://127.0.0.1:9080/hello"
Review comment:
Yes. Maybe we can change the status code.
Most of the documentation is using the 1980 port as a fake upstream. So we can assume people can get used to it.
We can't use 9080 port as it may cause a loop.
`httpbin.org` is another option, but it can't be accessed in the China mainland, and it only supports `http`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6219: docs: optimizing api-breaker documentation
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #6219:
URL: https://github.com/apache/apisix/pull/6219#discussion_r793790121
##########
File path: docs/en/latest/plugins/api-breaker.md
##########
@@ -90,7 +95,7 @@ curl "http://127.0.0.1:9080/apisix/admin/routes/1" -H 'X-API-KEY: edd1c9f034335f
Then. Like the configuration above, if your upstream service returns 500. 3 times in a row. The client will receive a 502 (break_response_code) response.
```shell
-$ curl -i -X POST "http://127.0.0.1:9080/get"
+$ curl -i -X POST "http://127.0.0.1:9080/hello"
Review comment:
A route is not configured api-breaker and which have a unavailable upstream, APISIX will return 502 error, so your example is not enough to say it's due to the 502 error returned by the api-breaker plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org