[jira] [Commented] (TC-39) LICENSE file is incomplete

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674916#comment-15674916 ] 

ASF GitHub Bot commented on TC-39:
----------------------------------

GitHub user dangogh opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/92

    [TC-39] add component licenses

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dangogh/incubator-trafficcontrol licenses

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit 91e91ccc64bf4b5a15bbac222b6c829247e6ecc9
Author: Dan Kirkwood <da...@gmail.com>
Date:   2016-11-17T21:45:21Z

    add component licenses

----


> LICENSE file is incomplete
> --------------------------
>
>                 Key: TC-39
>                 URL: https://issues.apache.org/jira/browse/TC-39
>             Project: Traffic Control
>          Issue Type: Bug
>            Reporter: Eric Friedrich
>            Priority: Minor
>
> Our LICENSE file only includes Apache License, but not the licenses of all our bundled dependencies. 
> From https://incubator.apache.org/guides/releasemanagement.html#best-practice-license:
> bq. "All the licenses on all the files to be included within a package should be included in the LICENSE document. This LICENSE (courtesy of Apache HTTPD) is a good example. The Apache License is at the top of the LICENSE document. After that, the license for each non-Apache licensed component is included, along with a clear explanation of which files that license applies to."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)