You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 17:41:48 UTC

[GitHub] [arrow] jonkeane commented on a diff in pull request #13038: MINOR: [R][Doc] encoding setting of `read_csv_arrow`

jonkeane commented on code in PR #13038:
URL: https://github.com/apache/arrow/pull/13038#discussion_r865107403


##########
r/R/csv.R:
##########
@@ -135,6 +135,8 @@
 #' write.csv(mtcars, file = tf)
 #' df <- read_csv_arrow(tf)
 #' dim(df)
+#' # Can specify the encoding of the file
+#' df <- read_csv_arrow(tf, read_options = CsvReadOptions$create(encoding = "utf8"))

Review Comment:
   I definitely think that `CsvReadOptions$create()` is not an ideal API for end users here. I'm very pro opening up a ticket to make that easier (even if it's "just" a mapping of a list to args like Nic is suggesting)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org