You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/01 23:10:59 UTC

[jira] [Commented] (BEAM-22) DirectPipelineRunner: support for unbounded collections

    [ https://issues.apache.org/jira/browse/BEAM-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311329#comment-15311329 ] 

ASF GitHub Bot commented on BEAM-22:
------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/411

    [BEAM-22] In the InProcessPipelineRunner, always compare keys by encoding

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Add StructuralKey to use in place of arbitrary objects, and use wherever user
    keys are used to lookup elements.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam encoded_object_equality

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/411.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #411
    
----
commit e2b03b4e670b560ddda659a9b29305e3889e8aee
Author: Thomas Groh <tg...@google.com>
Date:   2016-06-01T21:28:18Z

    Add Test for keys that have poor equality

commit 07ad81aca04ab1da419e712be795b14c8f8d6b2d
Author: Thomas Groh <tg...@google.com>
Date:   2016-06-01T21:28:49Z

    Use Structural Value keys instead of User Values
    
    This fixes problems with lookup by basing entirely on structural
    equality.

----


> DirectPipelineRunner: support for unbounded collections
> -------------------------------------------------------
>
>                 Key: BEAM-22
>                 URL: https://issues.apache.org/jira/browse/BEAM-22
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Davor Bonaci
>            Assignee: Thomas Groh
>
> DirectPipelineRunner currently runs over bounded PCollections only, and implements only a portion of the Beam Model.
> We should improve it to faithfully implement the full Beam Model, such as add ability to run over unbounded PCollections, and better resemble execution model in a distributed system.
> This further enables features such as a testing source which may simulate late data and test triggers in the pipeline. Finally, we may want to expose an option to select between "debug" (single threaded), "chaos monkey" (test as many model requirements as possible), and "performance" (multi-threaded).
> more testing (chaos monkey) 
> Once this is done, we should update this StackOverflow question:
> http://stackoverflow.com/questions/35350113/testing-triggers-with-processing-time/35401426#35401426



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)