You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Paul Querna <ch...@force-elite.com> on 2004/08/12 09:05:15 UTC

Re: [PATCH] pollset_poll() improvements

Can anyone take a look at the patch or commit it?

Thanks,

-Paul Querna

On Sat, 2004-07-24 at 19:46 -0700, Paul Querna wrote:
> On Mon, 2004-07-19 at 09:05 +0100, Joe Orton wrote:
> > On Sun, Jul 18, 2004 at 02:41:07PM -0700, Paul Querna wrote:
> > >  #elif defined(HAVE_EPOLL)
> > >      ev.events = get_epoll_event(descriptor->reqevents);
> > > +    ev.data.fd = pollset->nelts;
> > 
> > Did you use data.fd for this rather than data.u32 for a particular
> > reason?  Looks like the latter is a more natural choice since ->nelts is
> > also a uint32 (and not an fd)?
> 
> Attached is a slightly updated patch uses data.u32(data.fd was just a
> normal int...). Also updated it to not set data.fd in the remove
> function, since its not needed.
> 
> -Paul Querna