You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/05/08 05:24:46 UTC
Review Request 33968: HIVE-10644 create SHA2 UDF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33968/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-10644
https://issues.apache.org/jira/browse/HIVE-10644
Repository: hive-git
Description
-------
HIVE-10644 create SHA2 UDF
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java b043bdc882af7c0b83787526a5a55c9dc29c6681
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSha2.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSha2.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_sha2.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82
ql/src/test/results/clientpositive/udf_sha2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/33968/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 33968: HIVE-10644 create SHA2 UDF
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33968/
-----------------------------------------------------------
(Updated May 18, 2015, 10:24 p.m.)
Review request for hive and Jason Dere.
Changes
-------
added GenericUDFParamUtils
Bugs: HIVE-10644
https://issues.apache.org/jira/browse/HIVE-10644
Repository: hive-git
Description
-------
HIVE-10644 create SHA2 UDF
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFParamUtils.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSha2.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSha2.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_sha2.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82
ql/src/test/results/clientpositive/udf_sha2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/33968/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 33968: HIVE-10644 create SHA2 UDF
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33968/#review84217
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
<https://reviews.apache.org/r/33968/#comment135357>
In retrospect, I wish these paremeter utility methods had been put into a utility class rather than in GenericUDF - I feel like we are adding a lot of clutter to a class that users use to subclass.
Not sure if it's too late to do something about this - I see on HIVE-10580 there is some discussion about whether this can be removed.
Can you either create a new UDF params utility class for these, or just add these methods directly to GenericUDFSha2 for now?
- Jason Dere
On May 13, 2015, 5:48 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33968/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 5:48 a.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-10644
> https://issues.apache.org/jira/browse/HIVE-10644
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10644 create SHA2 UDF
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java b043bdc882af7c0b83787526a5a55c9dc29c6681
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSha2.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSha2.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_sha2.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82
> ql/src/test/results/clientpositive/udf_sha2.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33968/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 33968: HIVE-10644 create SHA2 UDF
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33968/
-----------------------------------------------------------
(Updated May 13, 2015, 5:48 a.m.)
Review request for hive and Jason Dere.
Changes
-------
patch #2: use Text.getBytes() instead of toString()
Bugs: HIVE-10644
https://issues.apache.org/jira/browse/HIVE-10644
Repository: hive-git
Description
-------
HIVE-10644 create SHA2 UDF
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java b043bdc882af7c0b83787526a5a55c9dc29c6681
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSha2.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSha2.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_sha2.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82
ql/src/test/results/clientpositive/udf_sha2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/33968/diff/
Testing
-------
Thanks,
Alexander Pivovarov