You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/01/14 19:35:37 UTC
Review Request 29889: Recover Docker containers when mesos slave is
in a container
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
This is a one mega patch and contains many reviews that's already on rb.
Diffs
-----
Dockerfile 35abf25
src/Makefile.am fc0c322
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp f1b8dfb
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
> On Jan. 14, 2015, 6:38 p.m., Dominic Hamon wrote:
> > can you use the 'depends on' to avoid containing other RBs?
This review is not meant to be merged, sorry probably should have put this on the description.
Since my changes spans lots of reviews, it's easier to have one diff to see everything.
In my other review chain it has the depends on populated.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review68064
-----------------------------------------------------------
On Jan. 14, 2015, 6:35 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 6:35 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a one mega patch and contains many reviews that's already on rb.
>
>
> Diffs
> -----
>
> Dockerfile 35abf25
> src/Makefile.am fc0c322
> src/docker/docker.hpp 3ebbc1f
> src/docker/docker.cpp 3a485a2
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp b7bf54a
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp f1b8dfb
> src/tests/docker_containerizer_tests.cpp 2105ae2
>
> Diff: https://reviews.apache.org/r/29889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review68064
-----------------------------------------------------------
can you use the 'depends on' to avoid containing other RBs?
- Dominic Hamon
On Jan. 14, 2015, 10:35 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 10:35 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a one mega patch and contains many reviews that's already on rb.
>
>
> Diffs
> -----
>
> Dockerfile 35abf25
> src/Makefile.am fc0c322
> src/docker/docker.hpp 3ebbc1f
> src/docker/docker.cpp 3a485a2
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp b7bf54a
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp f1b8dfb
> src/tests/docker_containerizer_tests.cpp 2105ae2
>
> Diff: https://reviews.apache.org/r/29889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review68517
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29889]
All tests passed.
- Mesos ReviewBot
On Jan. 16, 2015, 11:23 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 11:23 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a one mega patch and contains many reviews that's already on rb.
>
> This review is not meant to be merged, only provided for easier review.
>
>
> Diffs
> -----
>
> Dockerfile 35abf25
> docs/configuration.md 159516f
> docs/docker-containerizer.md a5438b7
> src/Makefile.am 07bea1f
> src/docker/docker.hpp 3ebbc1f
> src/docker/docker.cpp 3a485a2
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp b7bf54a
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
> src/tests/docker_containerizer_tests.cpp 2105ae2
>
> Diff: https://reviews.apache.org/r/29889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review69497
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29889]
All tests passed.
- Mesos ReviewBot
On Jan. 23, 2015, 5:49 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2015, 5:49 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a one mega patch and contains many reviews that's already on rb.
>
> This review is not meant to be merged, only provided for easier review.
>
>
> Diffs
> -----
>
> Dockerfile 35abf25
> docs/configuration.md 8a55f63
> docs/docker-containerizer.md a5438b7
> src/Makefile.am 07bea1f
> src/docker/docker.hpp 3ebbc1f
> src/docker/docker.cpp 3a485a2
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp b7bf54a
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a3c5c68
> src/tests/docker_containerizer_tests.cpp 2105ae2
>
> Diff: https://reviews.apache.org/r/29889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review79840
-----------------------------------------------------------
Bad patch!
Reviews applied: [29327, 29328]
Failed command: ./support/apply-review.sh -n -r 29328
Error:
2015-04-13 06:44:31 URL:https://reviews.apache.org/r/29328/diff/raw/ [2149/2149] -> "29328.patch" [1]
error: patch failed: src/slave/flags.hpp:311
error: src/slave/flags.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On April 13, 2015, 6:36 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 6:36 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a one mega patch and contains many reviews that's already on rb.
>
> This review is not meant to be merged, only provided for easier review.
>
>
> Diffs
> -----
>
> Dockerfile 35abf25
> docs/configuration.md 54c4e31
> docs/docker-containerizer.md a5438b7
> src/docker/docker.hpp 3ebbc1f
> src/docker/docker.cpp 3a485a2
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp 6893684
> src/slave/containerizer/docker.cpp f9fb078
> src/tests/docker_containerizer_tests.cpp c772d4c
>
> Diff: https://reviews.apache.org/r/29889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
(Updated April 22, 2015, 5:33 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This is a one mega patch and contains many reviews that's already on rb.
This review is not meant to be merged, only provided for easier review.
Diffs (updated)
-----
Dockerfile 35abf25
docs/configuration.md 54c4e31
docs/docker-containerizer.md a5438b7
src/Makefile.am 93c7c8a
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp 0d5289c
src/slave/containerizer/docker.cpp f9fb078
src/slave/flags.hpp d3b1ce1
src/slave/flags.cpp d0932b0
src/tests/docker_containerizer_tests.cpp b119a17
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
(Updated April 22, 2015, 5:33 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This is a one mega patch and contains many reviews that's already on rb.
This review is not meant to be merged, only provided for easier review.
Diffs (updated)
-----
Dockerfile 35abf25
docs/configuration.md 54c4e31
docs/docker-containerizer.md a5438b7
src/Makefile.am 93c7c8a
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp 0d5289c
src/slave/containerizer/docker.cpp f9fb078
src/slave/flags.hpp d3b1ce1
src/slave/flags.cpp d0932b0
src/tests/docker_containerizer_tests.cpp b119a17
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
(Updated April 13, 2015, 6:36 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This is a one mega patch and contains many reviews that's already on rb.
This review is not meant to be merged, only provided for easier review.
Diffs
-----
Dockerfile 35abf25
docs/configuration.md 54c4e31
docs/docker-containerizer.md a5438b7
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp 6893684
src/slave/containerizer/docker.cpp f9fb078
src/tests/docker_containerizer_tests.cpp c772d4c
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
(Updated April 13, 2015, 6:36 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This is a one mega patch and contains many reviews that's already on rb.
This review is not meant to be merged, only provided for easier review.
Diffs (updated)
-----
Dockerfile 35abf25
docs/configuration.md 54c4e31
docs/docker-containerizer.md a5438b7
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp 6893684
src/slave/containerizer/docker.cpp f9fb078
src/tests/docker_containerizer_tests.cpp c772d4c
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
(Updated Jan. 23, 2015, 5:49 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
This is a one mega patch and contains many reviews that's already on rb.
This review is not meant to be merged, only provided for easier review.
Diffs (updated)
-----
Dockerfile 35abf25
docs/configuration.md 8a55f63
docs/docker-containerizer.md a5438b7
src/Makefile.am 07bea1f
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp a3c5c68
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 29889: Recover Docker containers when mesos slave
is in a container
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 11:23 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description (updated)
-------
This is a one mega patch and contains many reviews that's already on rb.
This review is not meant to be merged, only provided for easier review.
Diffs (updated)
-----
Dockerfile 35abf25
docs/configuration.md 159516f
docs/docker-containerizer.md a5438b7
src/Makefile.am 07bea1f
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/slave/flags.hpp a4498e6
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29889/diff/
Testing
-------
make check
Thanks,
Timothy Chen