You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/18 05:02:22 UTC

[GitHub] [submarine] pingsutw commented on a change in pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment

pingsutw commented on a change in pull request #701:
URL: https://github.com/apache/submarine/pull/701#discussion_r690902918



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
             ></textarea>
           </nz-form-control>
         </nz-form-item>
+        <nz-form-item>
+          <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+          <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+            <!-- <textarea
+              nz-input
+              [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+              name="cmd"
+              formControlName="cmd"
+              id="cmd"
+              placeholder="Command for this template."
+            ></textarea> -->

Review comment:
       Could we remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org