You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/20 18:04:25 UTC

[GitHub] [nifi] markobean commented on pull request #6685: NIFI-10608 Copying Process Group now includes non-processor referenced controller services

markobean commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1359924493

   Reminder @joewitt - I did not merge because I am not a committer.
   
   As far as unit tests, it  may be reasonable to add, but this feels more like an integration testing option.  And might begin to go down the rabbit hole. If we add a test for this, do we also add a test to ensure all processors are copied with the process group? child process groups? funnels? etc. 
   
   @NissimShiman If you think adding a unit test for the copy operation is reasonable, is it also reasonable to have each component type tested?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org