[jira] [Commented] (PHOENIX-6073) IndexTool IndexDisableLoggingType can't be set to NONE

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176666#comment-17176666 ] 

Hadoop QA commented on PHOENIX-6073:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13009609/PHOENIX-6073-4.x.v1.patch
  against 4.x branch at commit 8e34b2bf14e5b6c45c7212104768792390cf0d06.
  ATTACHMENT ID: 13009609

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 0 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NotQueryWithGlobalImmutableIndexesIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsExtendedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CastAndCoerceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4093//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4093//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4093//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4093//console

This message is automatically generated.

> IndexTool IndexDisableLoggingType can't be set to NONE
> ------------------------------------------------------
>
>                 Key: PHOENIX-6073
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6073
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>         Attachments: PHOENIX-6073-4.x.v1.patch
>
>
> If a user explicitly sets the -dl parameter of the IndexTool to NONE to allow full logging, it will fail validation, even though this is something that should be allowed. There's an easy workaround by just leaving the parameter out entirely, but we should fix this. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)