You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/04/14 05:25:00 UTC
[GitHub] incubator-hawq pull request: HAWQ-672. Add python module pygresql ...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/606
HAWQ-672. Add python module pygresql back into hawq workspace
In this patch, all of the new added files come from the workspace after reverting HAWQ-271. Other changes mostly follow the original patch for HAWQ-271.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #606
----
commit 90816ddb5535bda8c0f24464dc86e2e5dd79389b
Author: Paul Guo <pa...@gmail.com>
Date: 2016-04-14T03:02:54Z
HAWQ-672. Add python module pygresql back into hawq workspace
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-672. Add python module pygresql ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/606#discussion_r59660199
--- Diff: tools/bin/ext/__init__.py ---
@@ -0,0 +1,306 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from error import *
+
+from tokens import *
+from events import *
+from nodes import *
+
+from loader import *
+from dumper import *
+
+try:
+ from cyaml import *
--- End diff --
We would better remove the codes not related to pygresql in this '__init__.py' file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-672. Add python module pygresql ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/606#issuecomment-216724353
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-672. Add python module pygresql ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/606#discussion_r59660154
--- Diff: tools/bin/generate-greenplum-path.sh ---
@@ -90,16 +90,9 @@ EOF
fi
#setup PYTHONPATH
-# OSX does NOT need pygresql/ path
-if [ "${PLAT}" = "Darwin" ] ; then
-cat <<EOF
-PYTHONPATH=\$GPHOME/lib/python:\$PYTHONPATH
-EOF
-else
cat <<EOF
PYTHONPATH=\$GPHOME/lib/python:\$GPHOME/lib/python/pygresql:\$PYTHONPATH
--- End diff --
Please check if we need '$GPHOME/lib/python/pygresql' in $PYTHONPATH ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-672. Add python module pygresql ...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/606#issuecomment-216724478
\uff0b1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-672. Add python module pygresql ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- closed the pull request at:
https://github.com/apache/incubator-hawq/pull/606
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---