You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/21 16:19:43 UTC

[GitHub] [beam] aaltay commented on a change in pull request #14690: [BEAM-12445] Moving streaming inserts with new client

aaltay commented on a change in pull request #14690:
URL: https://github.com/apache/beam/pull/14690#discussion_r674140743



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -292,6 +301,7 @@ def __init__(self, client=None, temp_dataset_id=None):
         http=get_new_http(),
         credentials=auth.get_service_credentials(),
         response_encoding='utf8')
+    self.gcp_bq_client = client or gcp_bigquery.Client()

Review comment:
       Is this a backward incompatible change, because users might pass a different type of a client that does not support `insert_rows_json` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org